Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 No localization for the error text if the email or password is wrong #418

Open
1 task done
atreeon opened this issue Oct 23, 2024 · 5 comments
Open
1 task done
Labels
auth blocked: customer response Waiting for customer response, e.g. more information was requested. enhancement New feature or request Keep Open Keep PR or issue open

Comments

@atreeon
Copy link

atreeon commented Oct 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues and found no duplicates.

What plugin is this bug for?

Firebase UI Auth

What platform(s) does this bug affect?

macOS

List of dependencies used.

firebase_core: ^3.6.0
firebase_auth: ^5.3.1
firebase_ui_auth: ^1.16.0
firebase_crashlytics: ^4.1.3
google_sign_in: ^6.2.1
firebase_ui_oauth_google: ^1.4.0

Steps to reproduce

Login with an incorrect email address.

Expected Behavior

After overriding every localization it seems that nothing sets the error message.

Actual Behavior

Screenshot 2024-10-23 at 17 55 53

Additional Information

No response

@atreeon atreeon changed the title 🐛 MacOS no localization for the error text if the email or password is wrong 🐛 No localization for the error text if the email or password is wrong Oct 23, 2024
@atreeon
Copy link
Author

atreeon commented Oct 23, 2024

    MaterialApp(
      localizationsDelegates: [
        FirebaseUILocalizations.withDefaultOverrides(const LabelOverrides()),
      ],

      home: AuthGate(appConfig: appConfig),

LabelOverrides.dart.txt

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Oct 23, 2024
@atreeon
Copy link
Author

atreeon commented Oct 23, 2024

Also, is this project being officially supported by anyone? @russellwheatley / @lesnitsky perhaps you know?

@russellwheatley
Copy link
Member

@atreeon - here are the error codes we currently support: https://github.com/firebase/FirebaseUI-Flutter/blob/main/packages/firebase_ui_auth/lib/src/widgets/error_text.dart#L13-L36

If you wish, you could open a PR for the particular error code you wish to have language support.

failing that, you can actually customise your own error codes following the instructions set out here: https://github.com/firebase/FirebaseUI-Flutter/blob/main/packages/firebase_ui_auth/lib/src/widgets/error_text.dart#L42-L54

@russellwheatley russellwheatley removed the Needs Attention OP created or responded to issue and it needs attention. label Oct 25, 2024
@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Oct 25, 2024
@russellwheatley russellwheatley added enhancement New feature or request auth blocked: customer response Waiting for customer response, e.g. more information was requested. and removed Needs Attention OP created or responded to issue and it needs attention. labels Oct 25, 2024
@atreeon
Copy link
Author

atreeon commented Nov 5, 2024

Unfortunately I don't have the time to open a PR at the moment but maybe early next year. Keep open please (personally I'd have categorised this as a bug).

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Nov 5, 2024
@russellwheatley russellwheatley added blocked: customer response Waiting for customer response, e.g. more information was requested. and removed blocked: customer response Waiting for customer response, e.g. more information was requested. Needs Attention OP created or responded to issue and it needs attention. labels Nov 12, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue with no recent activity label Dec 10, 2024
@russellwheatley russellwheatley added Keep Open Keep PR or issue open and removed Stale Issue with no recent activity labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth blocked: customer response Waiting for customer response, e.g. more information was requested. enhancement New feature or request Keep Open Keep PR or issue open
Projects
None yet
Development

No branches or pull requests

2 participants