Skip to content

React 17 compatibility #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoltenCoffee opened this issue Nov 17, 2020 · 2 comments
Open

React 17 compatibility #27

MoltenCoffee opened this issue Nov 17, 2020 · 2 comments

Comments

@MoltenCoffee
Copy link

bug report/feature request

What is the current behavior?

React 17 is not listed as a peerDependency, causing NPM to throw "could not resolve dependency" when using React 17.

What is the expected behavior?

As I believe this package is pefectly able to work under React 17, peerDependencies should be updated:

{
  "react": "^15.3.0 || ^16.0.0-0 || ^17.0.0",
  "react-dom": "^15.3.0 || ^16.0.0-0 || 17.0.0",
}

What's your environment?

Final form: 4.20.1
React-final-form: 6.5.2
React-final-form-html5-validation: 1.1.0

Node 15.2.0
NPM 7.0.8

@sethreidnz
Copy link

Bump? I was about to use this thinking it would be great. But it doesn't support the current version of React... Happy to contribute something if needed.

@MoltenCoffee
Copy link
Author

I'm already using it myself in React 17 without problems, I really think it's just a peerDependency issue (with NPM 7 handling those differently).

Installing with NPM flag ---legacy-peerd-deps fixes errors thrown by NPM, but we shouldn't have to do that. React-final-form seems to have been updated 3 days ago, so I have hope this will be fixed soon as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants