Skip to content

FieldArrayProps is not defined in v2.0.2 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ividic opened this issue Mar 4, 2019 · 9 comments · Fixed by #74
Closed

FieldArrayProps is not defined in v2.0.2 #72

ividic opened this issue Mar 4, 2019 · 9 comments · Fixed by #74

Comments

@ividic
Copy link

ividic commented Mar 4, 2019

What is the current behavior?

Version 2.0.2 has a FieldArrayProps is not defined error, which is not there in 2.0.1

Sandbox Link

Fork of the Simple Example, with the latest version of react-final-form-arrays: https://codesandbox.io/s/lyrp6961jq
@newsiberian
Copy link

screenshot_20190305_124829

@ThiefMaster
Copy link

A quick fix for this would be nice, since this breaks stuff for anyone using caret/tilde versions

ThiefMaster added a commit to indico/indico that referenced this issue Mar 6, 2019
@ThiefMaster
Pin react-final-form-arrays to 2.0.1
9365fd7 
2.0.2 is broken - final-form/react-final-form-arrays#72
@stevepopovich
Copy link

You can lock the version to 2.0.1

@ThiefMaster
Copy link

Sure, my point was that a semver-patch version change should not break things as doing so requires ALL users to pin an exact version, and unpin it again later.

@cloneali
Copy link

cloneali commented Mar 7, 2019

@erikras any help with this breaking change?

@luishdz1010
Copy link

This makes me lose confidence on semver for this project

@kjagiello kjagiello mentioned this issue Mar 8, 2019
Merged
@crobinson42
Copy link

I don't see any issues with the src code - seems like it might be a bundling issue where the rollup flow plugin missed stripping our this FieldArrayProps flow type and the bundle was published. @erikras any help here?

@NateRadebaugh
Copy link

Any update here?

rosskevin added a commit to rosskevin/react-final-form-arrays that referenced this issue Mar 22, 2019
@rosskevin
remove outdated rollup-plugin-flow causing final-form#72
aa24d7d
@rosskevin rosskevin mentioned this issue Mar 22, 2019
Merged
@rosskevin
Copy link
Contributor

I PR'd the bundle fix in #74.

erikras pushed a commit that referenced this issue Mar 29, 2019
@rosskevin @erikras
remove outdated rollup-plugin-flow causing #72 (#74)
4cd58c0
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove outdated rollup-plugin-flow causing es bundle error rosskevin/react-final-form-arrays
9 participants
@NateRadebaugh @rosskevin @ThiefMaster @luishdz1010 @stevepopovich @cloneali @crobinson42 @newsiberian @ividic