Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestF3LateBootstrap is flaky #847

Open
masih opened this issue Jan 24, 2025 · 0 comments
Open

TestF3LateBootstrap is flaky #847

masih opened this issue Jan 24, 2025 · 0 comments
Assignees

Comments

@masih
Copy link
Member

masih commented Jan 24, 2025

Over the course of latest development in this repo TestF3LateBootstrap is pupped up a number of times as being flaky. It's timeout has already been bumped to 1m, and it is the slowest test we have in this repo.

One cause that I have observed is that phases time out before messages are delivered which results in repeated base decision and causes assertions that check if a certain epoch is finalised take too long. A root cause is the way mock clock is used in the tests: it is used to grow the chain and gpbft. Another issue is the way clock advancing works relative to assertion checks. As is the test is very CPU hungry as it runs assertions in a hot-loop.

I captured this as a separate issue from #818 to emphasise the need for making this test run faster as it slows down development.

@github-project-automation github-project-automation bot moved this to Todo in F3 Jan 24, 2025
@masih masih self-assigned this Jan 24, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant