Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate compression into chainexchange topic #819

Open
Tracked by #792
masih opened this issue Jan 13, 2025 · 0 comments · May be fixed by #842
Open
Tracked by #792

Integrate compression into chainexchange topic #819

masih opened this issue Jan 13, 2025 · 0 comments · May be fixed by #842
Assignees
@masih
Milestone
M2: Mainnet Passi...

Comments

@masih
Copy link
Member

masih commented Jan 13, 2025

Add compression to messages published on chainexchange topic.
@masih masih self-assigned this Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Todo in F3 Jan 13, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Jan 13, 2025
@masih masih mentioned this issue Jan 13, 2025
Open
@masih masih moved this from Todo to In progress in F3 Jan 22, 2025
masih added a commit that referenced this issue Jan 22, 2025
@masih
Integrate zstd compression into chain exchange
7e3205a 
The GPBFT message exchange over pubsub already uses zstd compression on
top of CBOR encoded messages. The work here integrates the same style
of compression for chain exchange messages, with additional
unification of the encoding mechanism across the two.

The work refactors the root level encoding implementation into a generic
encoder decoder that both chain exchange and gpbft used. Tests and
benchmarks are updated to reflect this.

The benchmarking of partial gmessage encoding is also adjusted to fix a
few redundant statements and bugs in testing.

Fixes #819
@masih masih linked a pull request Jan 22, 2025 that will close this issue
Open
@masih masih moved this from In progress to In review in F3 Jan 22, 2025
masih added a commit that referenced this issue Jan 24, 2025
@masih
Integrate zstd compression into chain exchange
e771bca 
The GPBFT message exchange over pubsub already uses zstd compression on
top of CBOR encoded messages. The work here integrates the same style
of compression for chain exchange messages, with additional
unification of the encoding mechanism across the two.

The work refactors the root level encoding implementation into a generic
encoder decoder that both chain exchange and gpbft used. Tests and
benchmarks are updated to reflect this.

The benchmarking of partial gmessage encoding is also adjusted to fix a
few redundant statements and bugs in testing.

Fixes #819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: In review
Milestone
M2: Mainnet Passive Testing
Development

Successfully merging a pull request may close this issue.

Integrate zstd compression into chain exchange filecoin-project/go-f3
1 participant
@masih