Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of system exit codes #144

Closed
anorth opened this issue Mar 28, 2022 · 1 comment
Closed

Remove use of system exit codes #144

anorth opened this issue Mar 28, 2022 · 1 comment
Assignees
@anorth
Labels
P1

Comments

@anorth
Copy link
Member

anorth commented Mar 28, 2022 •
edited
Loading

Actors should not attempt to abort with a system exit code (values < 16). This is currently permitted by the VM only to match behaviour of the Go runtime (which drew the VM/actor boundary higher up). Remove all references to the system exit codes from the actors, using actor-level ones instead. See https://github.com/filecoin-project/fvm-specs/blob/main/07-errors.md

This will unblock filecoin-project/ref-fvm#253
@anorth anorth self-assigned this Mar 28, 2022
@anorth anorth added the P1 label Mar 28, 2022
@anorth anorth mentioned this issue Apr 8, 2022
Closed
Stebalien added a commit that referenced this issue Apr 11, 2022
@Stebalien
fix: propagate non-system exit codes in send
fde84c5 
The real fix is discussed in #144, but this version is strictly "more
correct" than the previous code.
Stebalien added a commit that referenced this issue Apr 11, 2022
@Stebalien
fix: improve send exit codes & comments
0093286 
Many of these are temporary (waiting on #144), but this is as correct as
we can get it for now.
@anorth
Copy link
Member Author

anorth commented Apr 14, 2022

Fixed by #191 and will improve further with #214

cc @dignifiedquire

@anorth anorth closed this as completed Apr 14, 2022
Repository owner moved this from In Progress to Done in Network v16 (Skyr) - FVM M1 Upgrade Apr 14, 2022
@anorth anorth mentioned this issue Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anorth anorth

Labels
P1
Projects
No open projects
Network v16 (Skyr) - FVM M1 Upgrade
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anorth