Skip to content

Commit d8e1164

Browse files
Merge pull request #39 from figma/ck/replace-ruby-dir
Revert ruby/ dir to michaelnyu/ci-queue/ruby @ ec48cc2
2 parents 10eb26b + bbe6b4f commit d8e1164

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+433
-1686
lines changed

.DS_Store

6 KB
Binary file not shown.

ruby/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ test/fixtures/log/test_data.json
44
/.byebug_history
55
/.bundle/
66
/.yardoc
7+
/Gemfile.lock
78
/_yardoc/
89
/coverage/
910
/doc/

ruby/.ruby-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

ruby/Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ source 'https://rubygems.org'
33
# Specify your gem's dependencies in ci-queue.gemspec
44
gemspec
55

6-
gem 'activesupport'
6+
gem 'activesupport', '~> 5.2.0'

ruby/Gemfile.lock

Lines changed: 0 additions & 113 deletions
This file was deleted.

ruby/ci-queue.gemspec

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ Gem::Specification.new do |spec|
1919
spec.homepage = 'https://github.com/Shopify/ci-queue'
2020
spec.license = 'MIT'
2121

22-
spec.required_ruby_version = '>= 2.7'
23-
2422
spec.files = lua_scripts + `git ls-files -z`.split("\x0").reject do |f|
2523
f.match(%r{^(test|spec|features)/})
2624
end
@@ -31,8 +29,6 @@ Gem::Specification.new do |spec|
3129

3230
spec.metadata['allowed_push_host'] = 'https://rubygems.org'
3331

34-
spec.add_runtime_dependency 'logger'
35-
3632
spec.add_development_dependency 'bundler'
3733
spec.add_development_dependency 'rake'
3834
spec.add_development_dependency 'minitest', ENV.fetch('MINITEST_VERSION', '~> 5.11')

ruby/dev.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
name: ci-queue
44

55
up:
6-
- ruby
6+
- ruby: 2.6.5
77
- bundler
8-
- redis
8+
- isogun
99

1010
commands:
11-
test: REDIS_URL=${REDIS_URL} bundle exec rake test TEST_FILES="$*"
11+
test: REDIS_URL=${REDIS_URL:-redis://ci-queue.railgun/0} bundle exec rake test TEST_FILES="$*"

ruby/isogun.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# This file is for Shopify employees development environment.
2+
# If you are an external contributor you don't have to bother with it.
3+
name: ci-queue
4+
5+
vm:
6+
ip_address: 192.168.64.245
7+
memory: 1G
8+
cores: 2
9+
services:
10+
- redis

ruby/lib/ci/queue.rb

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
require 'uri'
44
require 'cgi'
5-
require 'json'
65

76
require 'ci/queue/version'
87
require 'ci/queue/output_helpers'
@@ -21,21 +20,10 @@ module Queue
2120

2221
attr_accessor :shuffler, :requeueable
2322

24-
Error = Class.new(StandardError)
25-
2623
module Warnings
2724
RESERVED_LOST_TEST = :RESERVED_LOST_TEST
2825
end
2926

30-
GET_NOW = ::Time.method(:now)
31-
private_constant :GET_NOW
32-
def time_now
33-
# Mocks like freeze_time should be cleaned when ci-queue runs, however,
34-
# we experienced cases when tests were enqueued with wrong timestamps, so we
35-
# safeguard Time.now here.
36-
GET_NOW.call
37-
end
38-
3927
def requeueable?(test_result)
4028
requeueable.nil? || requeueable.call(test_result)
4129
end
@@ -55,7 +43,7 @@ def from_uri(url, config)
5543
Static
5644
when 'file', nil
5745
File
58-
when 'redis', 'rediss'
46+
when 'redis'
5947
require 'ci/queue/redis'
6048
Redis
6149
else

ruby/lib/ci/queue/bisect.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ def failing_test
2727
Static.new([config.failing_test], config).populate(@all_tests)
2828
end
2929

30-
def failing_test_present?
31-
@all_tests.find { |t| t.id == config.failing_test }
32-
end
33-
3430
def candidates
3531
Static.new(first_half + [config.failing_test], config).populate(@all_tests)
3632
end

0 commit comments

Comments
 (0)