Skip to content

Commit

Permalink
bolt: prevent duplicate index values from overwriting each other.
Browse files Browse the repository at this point in the history
  • Loading branch information
fiatjaf committed Jul 4, 2024
1 parent d3ad949 commit 01e4c2b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bolt/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func (b *BoltBackend) DeleteEvent(ctx context.Context, evt *nostr.Event) error {
// calculate all index keys we have for this event and delete them
for _, k := range getIndexKeysForEvent(evt) {
bucket := txn.Bucket(k.bucket)
bucket.Delete(k.key)
bucket.Delete(append(k.key, seqb...))
}

// delete the raw event
Expand Down
11 changes: 5 additions & 6 deletions bolt/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ func (b *BoltBackend) QueryEvents(ctx context.Context, filter nostr.Filter) (cha

for _, q := range queries {
q := q

pulled := 0 // this query will be hardcapped at this global limit

go b.db.View(func(txn *bolt.Tx) error {
Expand All @@ -63,14 +62,14 @@ func (b *BoltBackend) QueryEvents(ctx context.Context, filter nostr.Filter) (cha

c := bucket.Cursor()

k, v := c.Seek(q.startingPoint)
k, _ := c.Seek(q.startingPoint)
if k == nil {
k, v = c.Last()
k, _ = c.Last()
} else {
k, v = c.Prev()
k, _ = c.Prev()
}

for ; k != nil && bytes.HasPrefix(k, q.prefix); k, v = c.Prev() {
for ; k != nil && bytes.HasPrefix(k, q.prefix); k, _ = c.Prev() {
// "id" indexes don't contain a timestamp
if !q.skipTimestamp {
createdAt := binary.BigEndian.Uint32(k[len(k)-4:])
Expand All @@ -80,7 +79,7 @@ func (b *BoltBackend) QueryEvents(ctx context.Context, filter nostr.Filter) (cha
}

// fetch actual event
val := raw.Get(v)
val := raw.Get(k[len(k)-8:])
evt := &nostr.Event{}
if err := nostr_binary.Unmarshal(val, evt); err != nil {
log.Printf("bolt: value read error (id %x): %s\n", val[0:32], err)
Expand Down
2 changes: 1 addition & 1 deletion bolt/save.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (b *BoltBackend) SaveEvent(ctx context.Context, evt *nostr.Event) error {

for _, km := range getIndexKeysForEvent(evt) {
bucket := txn.Bucket(km.bucket)
if err := bucket.Put(km.key, seqb); err != nil {
if err := bucket.Put(append(km.key, seqb...), nil); err != nil {
return err
}
}
Expand Down

0 comments on commit 01e4c2b

Please sign in to comment.