Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

Commit 1937aac

Browse files
authored
Merge pull request #195 from thw26/master
Fix #194.
2 parents 272df89 + 79f58f7 commit 1937aac

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

LogosLinuxInstaller.sh

+13-11
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,8 @@ chooseInstallMethod() {
704704

705705
# Add AppImage to list
706706
if [[ "${DIALOG}" == "whiptail" ]] || [[ "${DIALOG}" == "dialog" ]]; then
707-
WINEBIN_OPTIONS+=("AppImage" "${APPDIR_BINDIR}/${WINE64_APPIMAGE_FULL_FILENAME}" ON)
707+
# NOTE: The missing quotations in this array are intentional and accounted for below.
708+
WINEBIN_OPTIONS+=("AppImage ${APPDIR_BINDIR}/${WINE64_APPIMAGE_FULL_FILENAME}" "AppImage of Wine64 ${WINE64_APPIMAGE_FULL_VERSION}" ON)
708709
elif [[ "${DIALOG}" == "zenity" ]]; then
709710
WINEBIN_OPTIONS+=(TRUE "AppImage" "AppImage of Wine64 ${WINE64_APPIMAGE_FULL_VERSION}" "${APPDIR_BINDIR}/${WINE64_APPIMAGE_FULL_FILENAME}")
710711
elif [[ "${DIALOG}" == "kdialog" ]]; then
@@ -723,11 +724,11 @@ chooseInstallMethod() {
723724

724725
if [[ "$WINEOPT" == *"/usr/bin/"* ]]; then
725726
WINEOPT_CODE="System"
726-
WINEOPT_DESCRIPTION="\"Use system's binary (i.e., /usr/bin/wine64). WINE must be 7.18-staging or later. Stable or Devel do not work.\""
727+
WINEOPT_DESCRIPTION="\"Use the system binary (i.e., /usr/bin/wine64). WINE must be 7.18-staging or later. Stable or Devel do not work.\""
727728
WINEOPT_PATH="${line}"
728729
elif [[ "$WINEOPT" == *"Proton"* ]]; then
729730
WINEOPT_CODE="Proton"
730-
WINEOPT_DESCRIPTION="\"Install using Steam's Proton fork of WINE.\""
731+
WINEOPT_DESCRIPTION="\"Install using the Steam Proton fork of WINE.\""
731732
WINEOPT_PATH="${line}"
732733
elif [[ "$WINEOPT" == *"PlayOnLinux"* ]]; then
733734
WINEOPT_CODE="PlayOnLinux"
@@ -741,7 +742,8 @@ chooseInstallMethod() {
741742

742743
# Create wine binary option array
743744
if [[ "${DIALOG}" == "whiptail" ]] || [[ "${DIALOG}" == "dialog" ]]; then
744-
WINEBIN_OPTIONS+=("${WINEOPT_CODE}" "${WINEOPT_PATH}" OFF)
745+
# NOTE: The missing quotations in this array are intentional and accounted for below.
746+
WINEBIN_OPTIONS+=("${WINEOPT_CODE} ${WINEOPT_PATH}" "${WINEOPT_DESCRIPTION}" OFF)
745747
elif [[ "${DIALOG}" == "zenity" ]]; then
746748
WINEBIN_OPTIONS+=(FALSE "${WINEOPT_CODE}" "${WINEOPT_DESCRIPTION}" "${WINEOPT_PATH}")
747749
elif [[ "${DIALOG}" == "kdialog" ]]; then
@@ -760,7 +762,7 @@ chooseInstallMethod() {
760762
installationChoice=$( $DIALOG --backtitle "${BACKTITLE}" --title "${TITLE}" --radiolist "${QUESTION_TEXT}" 0 0 "${WINEBIN_OPTIONS_LENGTH}" "${WINEBIN_OPTIONS[@]}" 3>&1 1>&2 2>&3 3>&- )
761763
read -r -a installArray <<< "${installationChoice}"
762764
WINEBIN_CODE=$(echo "${installArray[0]}" | awk -F' ' '{print $1}'); export WINEBIN_CODE
763-
WINE_EXE=$(echo "${installArray[1]}" | awk -F' ' '{print $2}'); export WINE_EXE
765+
WINE_EXE=$(echo "${installArray[0]}" | awk -F' ' '{print $2}'); export WINE_EXE
764766
elif [[ "${DIALOG}" == "zenity" ]]; then
765767
column_names=(--column "Choice" --column "Code" --column "Description" --column "Path")
766768
installationChoice=$(zenity --width=1024 --height=480 \
@@ -804,12 +806,6 @@ beginInstall() {
804806
fi
805807
if [ -n "${WINEBIN_CODE}" ]; then
806808
case "${WINEBIN_CODE}" in
807-
"System"|"Proton"|"PlayOnLinux"|"Custom")
808-
verbose && echo "Installing ${FLPRODUCT} Bible ${TARGETVERSION} using a ${WINEBIN_CODE} WINE64 binary…"
809-
if [ -z "${REGENERATE}" ]; then
810-
make_skel "none.AppImage"
811-
fi
812-
;;
813809
"AppImage"*)
814810
check_libs libfuse;
815811
verbose && echo "Installing ${FLPRODUCT} Bible ${TARGETVERSION} using ${WINE64_APPIMAGE_FULL_VERSION} AppImage…"
@@ -826,6 +822,12 @@ beginInstall() {
826822
export WINE_EXE="${APPDIR_BINDIR}/wine64"
827823
fi
828824
;;
825+
"System"|"Proton"|"PlayOnLinux"|"Custom")
826+
verbose && echo "Installing ${FLPRODUCT} Bible ${TARGETVERSION} using a ${WINEBIN_CODE} WINE64 binary…"
827+
if [ -z "${REGENERATE}" ]; then
828+
make_skel "none.AppImage"
829+
fi
830+
;;
829831
*)
830832
logos_error "WINEBIN_CODE error. Installation canceled!"
831833
esac

0 commit comments

Comments
 (0)