Make autocompletion case insensitive

[felixfbecker]

From @MikeVelazcoMtz on March 14, 2017 19:51

This is a bit akward for me because I'm used to this.

as an example:

<?php

$aVar = [];
$nFoo = 1;

If I want the editor to autocomplete $aVar and I wrote $a, $aVar appears on list to autocomplete, but if I write $av, the variable disapears from the list.

---

Another thing I noticed is that when I disable php.suggest.basic, the PHP core autocompletions stops working, I don't know if this is part of the normal behavior, but It would be excellent to have your own code + PHP core functions autocompletion.

Thanks for your work with this plugin, it's great!

Copied from original issue: felixfbecker/vscode-php-intellisense#90

[phil-nelson]

I'd suggest that it is smart about this, if the user types a mixed case then it is case sensitive but if it's all lower then case insensitive:

$aBc;
$abcd;

$ab produces both $aBc and $abcd
$aB only produces $aBc

However I'm not sure if this should be implemented in the server or client. Perhaps the server should always be case insensitive and it's up to the client to filter out case sensitivity (then it could be an client option.) However then each client needs to implement this logic.

[MikeVelazcoMtz]

Making autocompletion always case insensitive might be a wiser option.

It could be something weird for somebody writing on upper case not to see any autocompletion.

[phil-nelson]

Sorry that wasn't what I was suggesting, I didn't make it clear - if the user types mixed case, then they get a case sensitive result. If they type all lower or all upper then they get a case insensitive result. I think this is going to produce better results for each case. What I'm questioning is if this logic should be implemented in the server or client.

[MikeVelazcoMtz]

Thank you for making it clearer for me. I think that your suggestion would depend on the taste of the user. As my personal taste, I'd prefer to receive any result in a case insensitive form, even if I write with mixed case.

I think that this logic should be on every client, this way every user could control the behavior.