-
Notifications
You must be signed in to change notification settings - Fork 189
Closed
Labels
Description
I like the new auto completion tool and, I have a Laravel project that parses the files like so:
All 5568 PHP files parsed in 253 seconds. 178 MiB allocated.
When I type $someVar->
it takes about 2 seconds until the suggestions show up.
carlosramosgonz, binarious, jostillmanns, str, Lyrkan and 17 more
Metadata
Metadata
Assignees
Labels
Projects
Milestone
Relationships
Development
Select code repository
Activity
felixfbecker commentedon Feb 3, 2017
Hmm, aggregating the completion results should be O(n).
This would be interesting to profile.
TheColorRed commentedon Feb 3, 2017
Not sure if you saw this in the release notes of VSCode 1.9, but there is a php parser they are working on
https://github.com/Microsoft/tolerant-php-parser
Might be helpful in some way...
felixfbecker commentedon Feb 3, 2017
Yes, I am aware of it 🙂
autoferrit commentedon Jun 9, 2017
I have a similar issue on a Code igniter project. The autocompletion for class methods doesnt even pop up until I hit
ctrl + space
, then takes a few seconds. If i delete the->
and do it again, same thing. it doesnt cache the results either. but that is probably a different issue?jens1o commentedon Jun 10, 2017
@autoferrit afaik the results are not cached, but only the files where we get the results right. I think that's the bottleneck, yes.
binarious commentedon Oct 27, 2017
CTRL + Space takes about 12 seconds for me. I do have 10k PHP files:
macOS: 10.13
3,7 GHz Quad-Core
12 GB RAM
PHP: 7.1.10
Extension: 1.5.2
Code: 1.17.2
bmax commentedon Nov 11, 2017
Hi! @felixfbecker willing to work on this -- Do you have any suggestions on the best place to start? Profiling it with XDebug?
lndj commentedon Jan 27, 2018
Has anything help now?
binarious commentedon Jan 27, 2018
I had to switch to PHP Intelephense.
lndj commentedon Jan 30, 2018
@binarious is it faster?
binarious commentedon Jan 30, 2018
@lndj It just works for me. Suggestions and method signatures show up instantly on very large projects.
madbbb commentedon Mar 16, 2018
@TheColorRed
Have you disabled VSCode built-in suggestions? Try to set "php.suggest.basic" to false in settings.
18 remaining items
jens1o commentedon Nov 6, 2018
Thanks for the ping. Forgot to push. This is the current thing I've on. However, some tests are still failing currently. jens1o@f45c44f
felixfbecker commentedon Nov 6, 2018
Feel free to open a work-in-progress PR
MichaelBelgium commentedon Nov 6, 2018
It's getting parsed for me in less seconds but yeah doesn't change the fact it's slow in auto completing. Can't wait for a fix!
felixfbecker commentedon Nov 6, 2018
@MichaelBelgium if you can't wait, help out :)
MichaelBelgium commentedon Nov 6, 2018
Is this what needs to be done?
felixfbecker commentedon Nov 6, 2018
Yes
jens1o commentedon Nov 7, 2018
Okay, thanks for taking your time. :)
MichaelBelgium commentedon Nov 7, 2018
Anytime :) if it's only a simple merge ... surprised nobody did it before me.
perf: change index to a tree to speed up completion (#680)
felixfbecker commentedon Nov 11, 2018
🎉 This issue has been resolved in version 5.4.3 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
felixfbecker commentedon Nov 11, 2018
This is released for VS Code in https://github.com/felixfbecker/vscode-php-intellisense/releases/tag/v2.3.6 🎉
I think this also included these other PRs: https://github.com/felixfbecker/php-language-server/pulls?q=is%3Apr+is%3Aopen+author%3ADeclspeck+sort%3Aupdated-desc
midN commentedon Jun 7, 2019
Same, the issue is still happening, had to switch, now it's instant..