Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] SHOUTRRR_FILE #1024

Open
tiamilani opened this issue Jan 27, 2025 · 4 comments
Open

[feature request] SHOUTRRR_FILE #1024

tiamilani opened this issue Jan 27, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@tiamilani
Copy link

Hi :)

Thank you very much for the nice work! I was wondering, are you already planning to introduce a SHOUTRRR_FILE env variable?
I'm asking because a lot of times in shoutrrr urls there are tokens, which would be better to be kept as a secrets ;)

I've looked into the docs but I didn't find anything regarding this :/

thanks and all the best!

@tiamilani
Copy link
Author

At the moment I've overcome the issue by following:

https://stackoverflow.com/a/63870926
with #!/bin/sh.

And using the "edge-alpine" tag.

@favonia favonia added the enhancement New feature or request label Jan 29, 2025
@favonia
Copy link
Owner

favonia commented Jan 31, 2025

@tiamilani Thanks for the suggestion and sorry for the late response. I have a question: if both SHOUTRRR and SHOUTRRR_FILE are present, should that be an error?

I am currently working on IPv6 prefix updating in #1023. I can work on SHOUTRRR_FILE after that.

@tiamilani
Copy link
Author

tiamilani commented Jan 31, 2025 via email

@favonia
Copy link
Owner

favonia commented Jan 31, 2025

@tiamilani For *_TOKEN and *_TOKEN_FILE, the updater is "maximally tolerant," meaning that as long as they have the same value, the updater will not complain. The additional complexity here is that SHOUTRRR can actually contain multiple URLs. Therefore, the "maximally tolerant" criterion should consider the reordering of the URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants