Add radial flow model #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
force-pushed
the
feature/radial_flow
branch
from
9c30a8f to
851a03d
Compare
hannahlanzrath
force-pushed
the
feature/radial_flow
branch
from
851a03d to
703f87f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds radial flow models to CADET-Process (see also: https://cadet.github.io/v5.1.0/interface/unit_operations/radial_flow_models.html#radial-flow-models-config).
Moreover, this adds a new framework to specify parameter-parameter dependencies (see also: https://cadet.github.io/master/interface/parameter_dependencies.html).
Note, until the generalized column model is available in CADET-Process, this only works for finite volume discretization.
Todo