[WIP] Overhaul Fractionator #219
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
force-pushed
the
dev
branch
2 times, most recently
from
37fe8fb to
c51ffb5
Compare
schmoelder
force-pushed
the
overhaul_fractionator
branch
from
9001ed0 to
9916c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some general improvements for the fractionation module. However, it's still very much work in progress. We should also reconsider some aspects once we've decided how to proceed with the integration of Fields / StateStructure that was developed for CADET-Python-Simulator.
Potentially fixes #56, #19