Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 23, 2025

Fix compilation errors in email and owhisper-server crates

Summary

This PR fixes two compilation errors discovered during dependency analysis:

  1. email crate: Added conditional compilation attributes for macOS-only objc2 imports. The crate was failing to compile on Linux because it unconditionally imported objc2 modules that are only available on macOS. Added a stub implementation for non-macOS platforms that returns an error message.

  2. owhisper-server crate: Fixed incorrect type reference from hypr_agc::Agc to hypr_agc::VadAgc in the realtime audio processing code. The agc crate exports VadAgc, not Agc.

  3. schema.json: Auto-generated alphabetical reordering of JSON schema properties (side effect of build process).

Review & Testing Checklist for Human

  • Verify email functionality on macOS: Test that email composition still works correctly on macOS (the primary platform for this feature)
  • Test owhisper-server realtime mode: Verify that the realtime audio processing with AGC still functions correctly after the type name fix
  • Confirm schema.json changes are expected: The alphabetical reordering appears to be auto-generated, but verify this is intentional

Test Plan

  1. On macOS: Try using the email composition feature to ensure objc2 integration still works
  2. Run owhisper-server in realtime mode and verify audio processing with AGC works correctly
  3. Build the project on Linux/Windows to confirm the email crate compiles successfully

Notes

  • These fixes were discovered while checking for unused dependencies using cargo-machete
  • Both crates now compile successfully with cargo check --all-targets
  • The email crate stub for non-macOS platforms returns an error, which is appropriate since the feature is macOS-only
  • Session: https://app.devin.ai/sessions/ebe1f1db1fd246968b338cece40099a7
  • Requested by: yujonglee (@yujonglee)

- Add conditional compilation for macOS-only objc2 imports in email crate
- Add stub implementation for non-macOS platforms in email crate
- Fix incorrect type name Agc -> VadAgc in owhisper-server realtime.rs

Co-Authored-By: yujonglee <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1763915408-fix-compilation-errors

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 309a5d4
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/692337a97f47cd000846732d
😎 Deploy Preview https://deploy-preview-1825--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yujonglee yujonglee merged commit ffbab23 into main Nov 24, 2025
9 checks passed
@yujonglee yujonglee deleted the devin/1763915408-fix-compilation-errors branch November 24, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants