require Rack ~> 3.0

Author: leklund

lib/sidekiq_prometheus.rb

@@ -2,6 +2,7 @@
 
 require "benchmark"
 require "rack"
+require "rackup"
 require "prometheus/client"
 require "prometheus/middleware/exporter"
 require "sidekiq"
@@ -225,12 +226,12 @@ def metrics_server
     }
 
     unless metrics_server_logger_enabled?
-      opts[:Logger] = WEBrick::Log.new("/dev/null")
+      opts[:Logger] = WEBrick::Log.new(File::NULL)
       opts[:AccessLog] = []
     end
 
     @_metrics_server ||= Thread.new do
-      Rack::Handler::WEBrick.run(
+      Rackup::Handler::WEBrick.run(
         Rack::Builder.new {
           use Prometheus::Middleware::Exporter, registry: SidekiqPrometheus.registry
           run ->(_) { [301, {"Location" => "/metrics"}, []] }

sidekiq_prometheus.gemspec

@@ -28,7 +28,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "standard"
 
   spec.add_runtime_dependency "prometheus-client", ">= 2.0"
-  spec.add_runtime_dependency "rack", "< 3.0"
+  spec.add_runtime_dependency "rack", "~> 3.0"
+  spec.add_runtime_dependency "rackup", ">2.0"
   spec.add_runtime_dependency "redis"
   spec.add_runtime_dependency "sidekiq", "> 5.1"
   spec.add_runtime_dependency "webrick"

spec/sidekiq_prometheus/periodic_metrics_spec.rb

@@ -35,11 +35,13 @@
 
   describe "#start" do
     it "starts a reporter in a new thread" do
-      allow(Thread).to receive(:new)
+      silence do
+        allow(Thread).to receive(:new)
 
-      reporter.start
+        reporter.start
 
-      expect(Thread).to have_received(:new) { |&block| expect(block).to be_kind_of(Proc) }
+        expect(Thread).to have_received(:new) { |&block| expect(block).to be_kind_of(Proc) }
+      end
     end
   end
 

spec/spec_helper.rb

@@ -26,5 +26,5 @@ def silence
 end
 
 Sidekiq.configure_server do |cfg|
-  cfg.logger = Logger.new("/dev/null")
+  cfg.logger = Logger.new(File::NULL)
 end