Skip to content

Commit 06bfe28

Browse files
committed
add status 530 and *_operations_count metrics
1 parent b7796f5 commit 06bfe28

File tree

8 files changed

+78
-0
lines changed

8 files changed

+78
-0
lines changed

pkg/domain/process.go

+2
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ func process(serviceID, serviceName, datacenter, domain string, stats Stats, m *
5656
m.OriginStatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "503").Add(float64(stats.OriginStatus503))
5757
m.OriginStatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "504").Add(float64(stats.OriginStatus504))
5858
m.OriginStatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "505").Add(float64(stats.OriginStatus505))
59+
m.OriginStatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "530").Add(float64(stats.OriginStatus530))
5960
m.OriginStatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "5xx").Add(float64(stats.OriginStatus5xx))
6061
m.RequestsTotal.WithLabelValues(serviceID, serviceName, datacenter, domain).Add(float64(stats.Requests))
6162
m.RespBodyBytesTotal.WithLabelValues(serviceID, serviceName, datacenter, domain).Add(float64(stats.RespBodyBytes))
@@ -82,5 +83,6 @@ func process(serviceID, serviceName, datacenter, domain string, stats Stats, m *
8283
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "503").Add(float64(stats.Status503))
8384
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "504").Add(float64(stats.Status504))
8485
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "505").Add(float64(stats.Status505))
86+
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "530").Add(float64(stats.Status530))
8587
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, domain, "5xx").Add(float64(stats.Status5xx))
8688
}

pkg/domain/response.go

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ type Stats struct {
5757
OriginStatus503 uint64 `json:"origin_status_503"` // integer Number of responses received from origin with status code 503 (Service Unavailable).
5858
OriginStatus504 uint64 `json:"origin_status_504"` // integer Number of responses received from origin with status code 504 (Gateway Timeout).
5959
OriginStatus505 uint64 `json:"origin_status_505"` // integer Number of responses received from origin with status code 505 (HTTP Version Not Supported).
60+
OriginStatus530 uint64 `json:"origin_status_530"` // integer Number of responses received from origin with status code 530.
6061
OriginStatus5xx uint64 `json:"origin_status_5xx"` // integer Number of "Server Error" codes received from origin.
6162
Requests uint64 `json:"requests"` // integer Number of requests processed.
6263
RespBodyBytes uint64 `json:"resp_body_bytes"` // integer Total body bytes delivered.
@@ -83,5 +84,6 @@ type Stats struct {
8384
Status503 uint64 `json:"status_503"` // integer Number of responses received with status code 503 (Service Unavailable).
8485
Status504 uint64 `json:"status_504"` // integer Number of responses received with status code 504 (Gateway Timeout).
8586
Status505 uint64 `json:"status_505"` // integer Number of responses received with status code 505 (HTTP Version Not Supported).
87+
Status530 uint64 `json:"status_530"` // integer Number of responses delivered with status code 530.
8688
Status5xx uint64 `json:"status_5xx"` // integer Number of 5xx "Server Error" codes delivered.
8789
}

pkg/origin/process.go

+3
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ func process(serviceID, serviceName, datacenter, origin string, stats Stats, m *
5959
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcDelivery, "503").Add(float64(stats.Status503))
6060
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcDelivery, "504").Add(float64(stats.Status504))
6161
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcDelivery, "505").Add(float64(stats.Status505))
62+
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcDelivery, "530").Add(float64(stats.Status530))
6263
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcDelivery, "5xx").Add(float64(stats.Status5xx))
6364

6465
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "1xx").Add(float64(stats.ComputeStatus1xx))
@@ -82,6 +83,7 @@ func process(serviceID, serviceName, datacenter, origin string, stats Stats, m *
8283
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "503").Add(float64(stats.ComputeStatus503))
8384
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "504").Add(float64(stats.ComputeStatus504))
8485
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "505").Add(float64(stats.ComputeStatus505))
86+
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "530").Add(float64(stats.ComputeStatus530))
8587
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcCompute, "5xx").Add(float64(stats.ComputeStatus5xx))
8688

8789
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "1xx").Add(float64(stats.WafStatus1xx))
@@ -106,6 +108,7 @@ func process(serviceID, serviceName, datacenter, origin string, stats Stats, m *
106108
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "503").Add(float64(stats.WafStatus503))
107109
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "504").Add(float64(stats.WafStatus504))
108110
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "505").Add(float64(stats.WafStatus505))
111+
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "530").Add(float64(stats.WafStatus530))
109112
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, origin, srcWaf, "5xx").Add(float64(stats.WafStatus5xx))
110113

111114
// Latency stats are clearly from xxx_bucket{le="v"} metrics,

pkg/origin/response.go

+3
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ type Stats struct {
4747
Status503 uint64 `json:"status_503"` // Number of responses received with status code 503 (Service Unavailable) from origin.
4848
Status504 uint64 `json:"status_504"` // Number of responses received with status code 504 (Gateway Timeout) from origin.
4949
Status505 uint64 `json:"status_505"` // Number of responses received with status code 505 (HTTP Version Not Supported) from origin.
50+
Status530 uint64 `json:"status_530"` // Number of responses received from origin with status code 530.
5051
Status5xx uint64 `json:"status_5xx"` // Number of 5xx "Server Error" codes delivered from origin.
5152
Latency0to1 uint64 `json:"latency_0_to_1ms"` // Number of responses from origin with latency between 0 and 1 millisecond.
5253
Latency1to5 uint64 `json:"latency_1_to_5ms"` // Number of responses from origin with latency between 1 and 5 milliseconds.
@@ -86,6 +87,7 @@ type Stats struct {
8687
WafStatus503 uint64 `json:"waf_status_503"` // Number of responses received with status code 503 (Service Unavailable) received for origin requests made by the Fastly WAF.
8788
WafStatus504 uint64 `json:"waf_status_504"` // Number of responses received with status code 504 (Gateway Timeout) received for origin requests made by the Fastly WAF.
8889
WafStatus505 uint64 `json:"waf_status_505"` // Number of responses received with status code 505 (HTTP Version Not Supported) received for origin requests made by the Fastly WAF.
90+
WafStatus530 uint64 `json:"waf_status_530"` // Number of responses received with status code 530 received for origin requests made by the Fastly WAF.
8991
WafLatency0to1 uint64 `json:"waf_latency_0_to_1ms"` // Number of responses with latency between 0 and 1 millisecond received for origin requests made by the Fastly WAF.
9092
WafLatency1to5 uint64 `json:"waf_latency_1_to_5ms"` // Number of responses with latency between 1 and 5 milliseconds received for origin requests made by the Fastly WAF.
9193
WafLatency5to10 uint64 `json:"waf_latency_5_to_10ms"` // Number of responses with latency between 5 and 10 milliseconds received for origin requests made by the Fastly WAF.
@@ -124,6 +126,7 @@ type Stats struct {
124126
ComputeStatus503 uint64 `json:"compute_status_503"` // Number of responses received with status code 503 (Service Unavailable) for origin received by Compute@Edge.
125127
ComputeStatus504 uint64 `json:"compute_status_504"` // Number of responses received with status code 504 (Gateway Timeout) for origin received by Compute@Edge.
126128
ComputeStatus505 uint64 `json:"compute_status_505"` // Number of responses received with status code 505 (HTTP Version Not Supported) for origin received by Compute@Edge.
129+
ComputeStatus530 uint64 `json:"compute_status_530"` // Number of responses received with status code 530 for origin received by the Compute platform.
127130
ComputeLatency0to1 uint64 `json:"compute_latency_0_to_1ms"` // Number of responses with latency between 0 and 1 millisecond for origin received by Compute@Edge.
128131
ComputeLatency1to5 uint64 `json:"compute_latency_1_to_5ms"` // Number of responses with latency between 1 and 5 milliseconds for origin received by Compute@Edge.
129132
ComputeLatency5to10 uint64 `json:"compute_latency_5_to_10ms"` // Number of responses with latency between 5 and 10 milliseconds for origin received by Compute@Edge.

pkg/realtime/metrics.go

+6
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ type Metrics struct {
4343
ComputeBackendReqTotal *prometheus.CounterVec
4444
ComputeBackendRespBodyBytesTotal *prometheus.CounterVec
4545
ComputeBackendRespHeaderBytesTotal *prometheus.CounterVec
46+
ComputeCacheOperationsCount *prometheus.CounterVec
4647
ComputeExecutionTimeTotal *prometheus.CounterVec
4748
ComputeGlobalsLimitExceededTotal *prometheus.CounterVec
4849
ComputeGuestErrorsTotal *prometheus.CounterVec
@@ -137,6 +138,8 @@ type Metrics struct {
137138
MissSubTimeTotal *prometheus.CounterVec
138139
MissTimeTotal *prometheus.CounterVec
139140
ObjectSizeBytes *prometheus.HistogramVec
141+
ObjectStorageClassAOperationsCount *prometheus.CounterVec
142+
ObjectStorageClassBOperationsCount *prometheus.CounterVec
140143
OriginCacheFetchesTotal *prometheus.CounterVec
141144
OriginCacheFetchRespBodyBytesTotal *prometheus.CounterVec
142145
OriginCacheFetchRespHeaderBytesTotal *prometheus.CounterVec
@@ -258,6 +261,7 @@ func NewMetrics(namespace, subsystem string, nameFilter filter.Filter, r prometh
258261
ComputeBackendReqTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_bereq_total", Help: "Number of backend requests started."}, []string{"service_id", "service_name", "datacenter"}),
259262
ComputeBackendRespBodyBytesTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_beresp_body_bytes_total", Help: "Total body bytes received from backends (origins) by Compute@Edge."}, []string{"service_id", "service_name", "datacenter"}),
260263
ComputeBackendRespHeaderBytesTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_beresp_header_bytes_total", Help: "Total header bytes received from backends (origins) by Compute@Edge."}, []string{"service_id", "service_name", "datacenter"}),
264+
ComputeCacheOperationsCount: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_cache_operations_count", Help: "Number of cache operations executed by the Compute platform."}, []string{"service_id", "service_name", "datacenter"}),
261265
ComputeExecutionTimeTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_execution_time_total", Help: "The amount of active CPU time used to process your requests (in seconds)."}, []string{"service_id", "service_name", "datacenter"}),
262266
ComputeGlobalsLimitExceededTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_globals_limit_exceeded_total", Help: "Number of times a guest exceeded its globals limit."}, []string{"service_id", "service_name", "datacenter"}),
263267
ComputeGuestErrorsTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "compute_guest_errors_total", Help: "Number of times a service experienced a guest code error."}, []string{"service_id", "service_name", "datacenter"}),
@@ -352,6 +356,8 @@ func NewMetrics(namespace, subsystem string, nameFilter filter.Filter, r prometh
352356
MissSubTimeTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "miss_sub_time_total", Help: "Time spent inside the 'miss' Varnish subroutine (in seconds)."}, []string{"service_id", "service_name", "datacenter"}),
353357
MissTimeTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "miss_time_total", Help: "Total amount of time spent processing cache misses (in seconds)."}, []string{"service_id", "service_name", "datacenter"}),
354358
ObjectSizeBytes: prometheus.NewHistogramVec(prometheus.HistogramOpts{Namespace: namespace, Subsystem: subsystem, Name: "object_size_bytes", Help: "Histogram of count of objects served, bucketed by object size range.", Buckets: []float64{1024, 10240, 102400, 1.024e+06, 1.024e+07, 1.024e+08, 1.024e+09}}, []string{"service_id", "service_name", "datacenter"}),
359+
ObjectStorageClassAOperationsCount: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "object_storage_class_a_operations_count", Help: "A count of the number of Class A Object Storage operations."}, []string{"service_id", "service_name", "datacenter"}),
360+
ObjectStorageClassBOperationsCount: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "object_storage_class_b_operations_count", Help: "A count of the number of Class B Object Storage operations."}, []string{"service_id", "service_name", "datacenter"}),
355361
OriginCacheFetchesTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "origin_cache_fetches_total", Help: "The total number of completed requests made to backends (origins) that returned cacheable content."}, []string{"service_id", "service_name", "datacenter"}),
356362
OriginCacheFetchRespBodyBytesTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "origin_cache_fetch_resp_body_bytes_total", Help: "Body bytes received from origin for cacheable content."}, []string{"service_id", "service_name", "datacenter"}),
357363
OriginCacheFetchRespHeaderBytesTotal: prometheus.NewCounterVec(prometheus.CounterOpts{Namespace: namespace, Subsystem: subsystem, Name: "origin_cache_fetch_resp_header_bytes_total", Help: "Header bytes received from an origin for cacheable content."}, []string{"service_id", "service_name", "datacenter"}),

pkg/realtime/process.go

+4
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ func process(serviceID, serviceName, datacenter string, stats Datacenter, m *Met
5656
m.ComputeBackendReqTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeBackendReqTotal))
5757
m.ComputeBackendRespBodyBytesTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeBackendRespBodyBytesTotal))
5858
m.ComputeBackendRespHeaderBytesTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeBackendRespHeaderBytesTotal))
59+
m.ComputeCacheOperationsCount.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeCacheOperationsCount))
5960
m.ComputeExecutionTimeTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeExecutionTimeMilliseconds) / 10000.0)
6061
m.ComputeGlobalsLimitExceededTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeGlobalsLimitExceededTotal))
6162
m.ComputeGuestErrorsTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ComputeGuestErrorsTotal))
@@ -154,6 +155,8 @@ func process(serviceID, serviceName, datacenter string, stats Datacenter, m *Met
154155
m.MissSubCountTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.MissSubCount))
155156
m.MissSubTimeTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.MissSubTime))
156157
m.MissTimeTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.MissTime))
158+
m.ObjectStorageClassAOperationsCount.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ObjectStorageClassAOperationsCount))
159+
m.ObjectStorageClassBOperationsCount.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.ObjectStorageClassBOperationsCount))
157160
m.OriginCacheFetchesTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.OriginCacheFetches))
158161
m.OriginCacheFetchRespBodyBytesTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.OriginCacheFetchRespBodyBytes))
159162
m.OriginCacheFetchRespHeaderBytesTotal.WithLabelValues(serviceID, serviceName, datacenter).Add(float64(stats.OriginCacheFetchRespHeaderBytes))
@@ -237,6 +240,7 @@ func process(serviceID, serviceName, datacenter string, stats Datacenter, m *Met
237240
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, "503").Add(float64(stats.Status503))
238241
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, "504").Add(float64(stats.Status504))
239242
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, "505").Add(float64(stats.Status505))
243+
m.StatusCodeTotal.WithLabelValues(serviceID, serviceName, datacenter, "530").Add(float64(stats.Status530))
240244
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, "1xx").Add(float64(stats.Status1xx))
241245
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, "2xx").Add(float64(stats.Status2xx))
242246
m.StatusGroupTotal.WithLabelValues(serviceID, serviceName, datacenter, "3xx").Add(float64(stats.Status3xx))

0 commit comments

Comments
 (0)