Getting unexpected DeprecationWarning when running unit tests using SQLModel v0.0.12

[miguelsousa]

First Check

• I added a very descriptive title here.
• I used the GitHub search to find a similar question and didn't find it.
• I searched the SQLModel documentation, with the integrated search.
• I already searched in Google "How to X in SQLModel" and didn't find any information.
• I already read and followed all the tutorial in the docs and didn't find an answer.
• I already checked if it is not related to SQLModel but to Pydantic.
• I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

• I commit to help with one of those options 👆

Example Code

Contents of main.py

from contextlib import asynccontextmanager
from typing import Optional

from fastapi import Depends, FastAPI, HTTPException
from sqlmodel import Field, Session, SQLModel, create_engine, select


class Hero(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    name: str = Field(index=True)
    secret_name: str
    age: Optional[int] = Field(default=None, index=True)


sqlite_file_name = "database.db"
sqlite_url = f"sqlite:///{sqlite_file_name}"

connect_args = {"check_same_thread": False}
engine = create_engine(sqlite_url, echo=True, connect_args=connect_args)


def get_session():
    with Session(engine) as session:
        yield session


@asynccontextmanager
async def lifespan(app: FastAPI):
    SQLModel.metadata.create_all(engine)
    yield


app = FastAPI(lifespan=lifespan)


@app.get("/heroes/")
def read_heroes(session: Session = Depends(get_session)):
    heroes = session.exec(select(Hero)).all()
    return heroes


@app.get("/heroes/{hero_id}")
def read_hero(*, session: Session = Depends(get_session), hero_id: int):
    hero = session.get(Hero, hero_id)
    if not hero:
        raise HTTPException(status_code=404, detail="Hero not found")
    return hero

Contents of test_main.py

import pytest
from fastapi.testclient import TestClient
from sqlmodel import Session, SQLModel, create_engine
from sqlmodel.pool import StaticPool

from main import Hero, app, get_session


@pytest.fixture(name="session")
def session_fixture():
    engine = create_engine(
        "sqlite://", connect_args={"check_same_thread": False}, poolclass=StaticPool
    )
    SQLModel.metadata.create_all(engine)
    with Session(engine) as session:
        yield session
    SQLModel.metadata.drop_all(engine)


@pytest.fixture(name="client")
def client_fixture(session: Session):
    def get_session_override():
        return session

    app.dependency_overrides[get_session] = get_session_override
    client = TestClient(app)
    yield client
    app.dependency_overrides.clear()


def test_read_heroes(session: Session, client: TestClient):
    hero_1 = Hero(name="Deadpond", secret_name="Dive Wilson")
    hero_2 = Hero(name="Rusty-Man", secret_name="Tommy Sharp", age=48)
    session.add(hero_1)
    session.add(hero_2)
    session.commit()

    response = client.get("/heroes/")
    data = response.json()

    assert response.status_code == 200

    assert len(data) == 2
    assert data[0]["name"] == hero_1.name
    assert data[0]["secret_name"] == hero_1.secret_name
    assert data[0]["age"] == hero_1.age
    assert data[0]["id"] == hero_1.id
    assert data[1]["name"] == hero_2.name
    assert data[1]["secret_name"] == hero_2.secret_name
    assert data[1]["age"] == hero_2.age
    assert data[1]["id"] == hero_2.id


def test_read_hero(session: Session, client: TestClient):
    hero_1 = Hero(name="Deadpond", secret_name="Dive Wilson")
    session.add(hero_1)
    session.commit()

    response = client.get(f"/heroes/{hero_1.id}")
    data = response.json()

    assert response.status_code == 200
    assert data["name"] == hero_1.name
    assert data["secret_name"] == hero_1.secret_name
    assert data["age"] == hero_1.age
    assert data["id"] == hero_1.id

Description

When running pytests, I'm getting unexpected DeprecationWarning messages. What makes it unexpected is that the execute() method is not used anywhere in the example code.
The warning output is:

test_main.py::test_read_hero
  /opt/miniconda3/envs/sqlmodel/lib/python3.10/site-packages/sqlalchemy/orm/loading.py:690: DeprecationWarning: 
          🚨 You probably want to use `session.exec()` instead of `session.execute()`.
  
          This is the original SQLAlchemy `session.execute()` method that returns objects
          of type `Row`, and that you have to call `scalars()` to get the model objects.
  
          For example:
  
          ```Python
          heroes = session.execute(select(Hero)).scalars().all()
          ```
  
          instead you could use `exec()`:
  
          ```Python
          heroes = session.exec(select(Hero)).all()
          ```
          
    session.execute(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Steps to reproduce

1. Save the code snippets to each file
2. Run this command to execute the tests:

   pytest test_main.py -v

Operating System

Linux, macOS

Operating System Details

No response

SQLModel Version

0.0.12

Python Version

3.10.13

Additional Context

No response

[miguelsousa]

The warnings are also visible in SQLModel's own test runs, for example https://github.com/tiangolo/sqlmodel/actions/runs/6913661847/job/18810721739#step:11:187

[mattmess1221]

Adding category=None to the @deprecated() decorator seems to disable the runtime warnings, but still have static warnings from the type checker.