Skip to content

Commit 1a8af31

Browse files
committed
Enable create issue command only on active session
1 parent d12566c commit 1a8af31

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ However, you shouldn't have to fill out a placeholder for yourself, VSCode shoul
150150

151151
Since VSCode is aimed to be as general as possible, some functionality might never be represented in the UI - as such it might appear unintuitive. [Describing such functionality is found here](docs/USAGE.md), like setting watch points, formatting displayed values etc.
152152

153-
If Midas behaves strangely, there exists a midas command (`Create github issue log`) that aims to make reports easier to file. It creates a new virtual document with the error logs. Please use this when filing a issue. It gets the `rr` and `gdb` version from the `launch.json` configuration you've provided and also tries to figure out the Linux distro you are using. To access this midas command open the control panel (default shortcut for VSCode is `ctrl+shift+P`). and type `Create github issue". Example below.
154-
![Issue logs](docs/how_to_create_logs.gif). Either save this file and add it to the issue or paste it into the issue itself.
153+
If Midas behaves strangely, there exists a midas command (`Create github issue log`) that aims to make reports easier to file. It creates a new virtual document with the error logs. Please use this when filing a issue. It gets the `rr` and `gdb` version from the `launch.json` configuration of the active running debug session you've provided and also tries to figure out the Linux distro you are using. To access this midas command open the control panel (default shortcut for VSCode is `ctrl+shift+P`). and type `Create github issue". Example below.
154+
![Issue logs](docs/how_to_create_logs.gif). Either save this file and add it to the issue or paste it into the issue itself. This command needs to be executed while the debug session is active & running in order for it to work. The logs it copies from are non-persistent to not swamp your file system.
155155

156156
## Development
157157

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
{
4141
"command": "midas.issue-report",
4242
"title": "Create github issue log",
43-
"shortTitle": "Prepare Github Issue logs"
43+
"shortTitle": "Prepare Github Issue logs",
44+
"enablement": "midas.Running == true"
4445
},
4546
{
4647
"command": "midas.rr-record",

0 commit comments

Comments
 (0)