Skip to content
This repository was archived by the owner on Apr 7, 2021. It is now read-only.

Version mismatch of falco-operator container tag #2

Open
nestorsalceda opened this issue Feb 28, 2019 · 4 comments
Open

Version mismatch of falco-operator container tag #2

nestorsalceda opened this issue Feb 28, 2019 · 4 comments

Comments

@nestorsalceda
Copy link

In DockerHub, there is a falco-operator image which has the 0.12.1 tag. But in the Makefile and in the deployment manifests the tag value is v0.12.1.

AFAIK, the convention followed for Falco is to use vX.XX.X for git tag name and use just X.XX.X for images uploaded to DockerHub.

So I think, this should be fixed because otherwise an ErrImagePull is received.

Thanks!

@mumoshu
Copy link
Collaborator

mumoshu commented Apr 5, 2019

@nestorsalceda Thanks!

I'm going to fix this, but how should I push the resulting image to the dockerhub "falcosecurity" org?

Would you mind inviting me (@mumoshu in dockerhub as well) to the dockerhub org, or "falco-operator" docker repo under the org, so that I can probably push it myself?

@acim
Copy link
Contributor

acim commented May 29, 2019

You should either tag your Docker images with prefix v or just keep tagging as you do and remove v from the Helm chart values. I will PR with the second solution today.

@poiana
Copy link

poiana commented Nov 18, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

1 similar comment
@poiana
Copy link

poiana commented Feb 16, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants