Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate browserify JS modules #2

Open
mlnmln opened this issue Jan 7, 2018 · 1 comment
Open

Investigate browserify JS modules #2

mlnmln opened this issue Jan 7, 2018 · 1 comment
Assignees

Comments

@mlnmln
Copy link
Member

mlnmln commented Jan 7, 2018

When importing factorial-components-image from remote.

$ browserify source/index.js -o public/index.js -t [ babelify --presets [ env ] ]

/Users/milanmatull/Documents/dev/web/factorial-patterns-test/node_modules/factorial-components-image/components-image.js:6
import 'picturefill';
^
ParseError: 'import' and 'export' may appear only with 'sourceType: module'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@mlnmln mlnmln self-assigned this Jan 7, 2018
@mlnmln
Copy link
Member Author

mlnmln commented Mar 6, 2019

Browserify expects commonjs modules, needs a build step to UMD format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant