Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File deletion from mounted directory hangs firmware #181

Open
snhirsch opened this issue Mar 1, 2021 · 6 comments
Open

File deletion from mounted directory hangs firmware #181

snhirsch opened this issue Mar 1, 2021 · 6 comments
Labels

Comments

@snhirsch
Copy link

snhirsch commented Mar 1, 2021

Title says it. If I try to delete any file from a mounted directory the firmware immediately hangs with both green LEDs lit (PetSD). I have to power cycle the PetSD, restart xd2031 and reboot PET to recover. 100% repeatable.

@fachat fachat added the bug label Mar 2, 2021
@fachat
Copy link
Owner

fachat commented Mar 2, 2021

Can you provide more details? I know it may be frustrating, I still have these questions/assumptions:

  • there is only a single device on the IEEE bus next to your PET; that's the petSD?
  • there are no special characters in the filename? You addressed a normal file, not one in a directory?
  • "mounted directory" means a directory on the host, not in a disk image?
  • Which branch/version of xd2031 did you use?

@snhirsch
Copy link
Author

snhirsch commented Mar 2, 2021

There are two attached devices: Hardbox hard disk (Unit 8) and PetSD (Unit 10). Not sure if a space is considered as a 'special character', but the most recent file name is 'os9 small copy'. It is a normal file. The directory was indeed a directory on the host - not in an image. I'm using:

hirsch@beaglebone:~/work/XD2031$ git status
Refresh index: 100% (1929/1929), done.
On branch 177-relpos
Your branch is up to date with 'origin/177-relpos'.

@fachat
Copy link
Owner

fachat commented Mar 2, 2021

Can you try branch 181-delete-crash ? There was a memory corruption bug, I had a different crash than yours, but that may be the cause of yours too

@snhirsch
Copy link
Author

snhirsch commented Mar 3, 2021

The new branch appears to have fixed the issue on mounted host directories, but I'm still unable to remove files from a D64 image. Here's the test case:

os9-systemdisk.d64.gz

There is a single file in that image. When I attempt to remove it under XD2031 the firmware crashes.

@snhirsch
Copy link
Author

snhirsch commented Mar 3, 2021

More on this: XD2031 has issues with '/' in filenames. I can understand this when targeting a Linux directory, but I'm unable to copy a file named 'format.os/9' to a mounted D64 image. The OPEN operation appears to succeed, but subsequent writes fail with a complaint that the target is not found.

@fachat
Copy link
Owner

fachat commented Mar 21, 2021

Can you have a look at branch 181-delete-crash? Should have fixed the issue with deleting the file you mentioned, and hopefully also other issues with "/" in Dxx files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants