Skip to content

Make a release #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndmitchell opened this issue Aug 19, 2021 · 4 comments
Closed

Make a release #29

ndmitchell opened this issue Aug 19, 2021 · 4 comments
Assignees

Comments

@ndmitchell
Copy link
Contributor

As promised in #28

@ndmitchell ndmitchell self-assigned this Aug 19, 2021
@ndmitchell
Copy link
Contributor Author

Done with version 0.5.0.

@gkmngrgn
Copy link

Hey @ndmitchell, I think we need a new release again, because I'm getting this error with nightly:

   Compiling starlark v0.5.0
error: invalid format string: expected `'}'`, found `'\''`
   --> /home/goedev/.cargo/registry/src/github.com-1ecc6299db9ec823/starlark-0.5.0/src/values/interpolation.rs:197:58
    |
197 |             ('{', ..) => return Err(anyhow!("Unmatched '{' in format string")),
    |                                                         -^ expected `}` in format string
    |                                                         |
    |                                                         because of this opening brace
    |
    = note: if you intended to print `{`, you can escape it using `{{`

error: invalid format string: expected `'}'`, found `'\''`
   --> /home/goedev/.cargo/registry/src/github.com-1ecc6299db9ec823/starlark-0.5.0/src/values/interpolation.rs:213:39
    |
213 |         _ => Err(anyhow!("Unmatched '{' in format string")),
    |                                      -^ expected `}` in format string
    |                                      |
    |                                      because of this opening brace
    |
    = note: if you intended to print `{`, you can escape it using `{{`

error: could not compile `starlark` due to 2 previous errors

For now, I fixed this problem adding starlark with git path to the dependencies list. Thanks.

@ndmitchell
Copy link
Contributor Author

The issue is a newer anyhow release broke the anyhow! formatting strings. I'll make a new release on Monday.

facebook-github-bot pushed a commit that referenced this issue Nov 22, 2021
Summary: As requested in #29 (comment). The changelog represents 538 commits since the last release, so took a while to write!

Reviewed By: krallin

Differential Revision: D32592072

fbshipit-source-id: 63cd0d048c812ee41872843aa495cee6db786471
@ndmitchell
Copy link
Contributor Author

ndmitchell commented Nov 22, 2021

Done - 0.6.0 is now out @gkmngrgn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants