Skip to content

Commit e23e9ad

Browse files
tido64meta-codesync[bot]
authored andcommitted
Fix 'hermes-compiler' not being resolved correctly (#54667)
Summary: Fixed `hermes-compiler` not being resolved correctly when your repo is set up as a monorepo using pnpm. ## Changelog: [GENERAL] [FIXED] - Fixed `hermes-compiler` not being resolved correctly when your repo is set up as a monorepo using pnpm. Pull Request resolved: #54667 Test Plan: n/a Reviewed By: cortinico Differential Revision: D87873273 Pulled By: cipolleschi fbshipit-source-id: 4d60a00ae579bc4a671d6536de4dd02bdefef6c8
1 parent 7163033 commit e23e9ad

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

packages/react-native/sdks/hermes-engine/hermes-engine.podspec

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,7 @@ Pod::Spec.new do |spec|
7272
# In other cases, when using Hermes V1, the prebuilt versioned binaries can be used.
7373
if source_type != HermesEngineSourceType::LOCAL_PREBUILT_TARBALL
7474
hermes_compiler_path = File.dirname(Pod::Executable.execute_command('node', ['-p',
75-
'require.resolve(
76-
"hermes-compiler",
77-
{paths: [process.argv[1]]}
78-
)', __dir__]).strip
75+
"require.resolve(\"hermes-compiler\", {paths: [\"#{react_native_path}\"]})", __dir__]).strip
7976
)
8077

8178
spec.user_target_xcconfig = {

0 commit comments

Comments
 (0)