Skip to content

Action always passes when gem push fails #15

Description

@dmorgan-fa

The lines:

if ! gem push --key="$KEY" --host "$GEM_HOST" "$GEM_FILE" >push.out; then
    gemerr=$?
   [...]
   exit $gemerr
fi

Always return 0:

if ! gem push boop; then echo $?; fi       #   File doesn't exist, exit state is 0
ERROR:  While executing gem ... (Gem::Package::FormatError)
    No such file or directory @ rb_sysopen - boop
0

This causes the action to pass when it should fail, see:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions