Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly Mirrored Corpses doesn't work well with rotations #2212

Open
MrAlaux opened this issue Feb 25, 2025 · 2 comments
Open

Randomly Mirrored Corpses doesn't work well with rotations #2212

MrAlaux opened this issue Feb 25, 2025 · 2 comments

Comments

@MrAlaux
Copy link
Collaborator

MrAlaux commented Feb 25, 2025

Tested in the latest master artifact (Win-64).

Simply put, if the Randomly Mirrored Corpses effect is applied to something with rotations, the thing's rotation will look weird.

In this case, I replaced one of the gibbed-player decorations with a chair, which is affected:

2025-02-25.04-40-22-1.mp4

Options to fix this would be to not apply the effect to things modified by DeHackEd, or to perform a thorough analysis to determine if the effect should be applied, which I think would be optimal. However, in case the latter is too complex, I propose something different: flipping the sprite just like we do currently, but using the opposite rotation, i.e. (8 - rot) & 7. What do you think?

@MrAlaux MrAlaux changed the title _Randomly Mirrored Corpses_ doesn't work well with rotations Randomly Mirrored Corpses doesn't work well with rotations Feb 25, 2025
@fabiangreffrath
Copy link
Owner

flipping the sprite just like we do currently, but using the opposite rotation, i.e. (8 - rot) & 7.

How would this look like in the video?

@MrAlaux
Copy link
Collaborator Author

MrAlaux commented Feb 25, 2025

flipping the sprite just like we do currently, but using the opposite rotation, i.e. (8 - rot) & 7.

How would this look like in the video?

With this specific set of sprites, it would look pretty much identical to how it looks in the video.

Here's a better example, halfway through this video I toggle a setting to flip the sprite and use the opposite rotation (I already have that system in place for use with a feature to "flip levels"):

2025-02-25.05-26-17-1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants