-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Skybox and FOV thingy #2209
Comments
You can check out the height-extended skies from the following project, as well. The latest release goes to the maximum height that Woof supports with freelook. |
Needless to say, that isn't a universal solution. Quick reminder that Nugget has a feature to fix this, which I could port over. See: 2025-02-21.20-03-39-1.mp4 |
This looks indeed quite good (though not perfect, if you look e.g. at the top of the mountain of the left side relative to the menu text). Could you point us to the code or file a PR, please? |
I'll file a PR myself later. I made other changes to sky stretching that this might rely on, though I doubt it. |
Isn't this pretty much it? --- a/src/r_main.c
+++ b/src/r_main.c
@@ -633,7 +633,7 @@ void R_ExecuteSetViewSize (void)
while (FixedMul(pspriteiscale, pspritescale) < FRACUNIT)
pspriteiscale++;
- if (custom_fov == FOV_DEFAULT)
+ if (custom_fov >= FOV_DEFAULT)
{
skyiscale = FixedDiv(SCREENWIDTH, viewwidth_nonwide);
} |
Bildschirmaufzeichnung.vom.2025-02-22.13-54-22.mp4 |
Huh, I never thought of that. |
Thinking about it more, I believe your patch would always stretch the sky, even if the sky texture is tall enough to accomodate a higher FOV. Do you want that? I personally vouch for stretching skies only as much as necessary. |
Would it be possible to make it so skyboxes scale with FOV? If you play with a FOV higher than the default it will leave gaps in the background, the higher the FOV the bigger the gap.
Here's a low effort screenshot. It's barely noticeable on e1m1 but very noticeable on other maps:
GZDoom added a "fix" for this a little while ago. Looks pretty good.
The text was updated successfully, but these errors were encountered: