Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A_RemoveFlags doesn't work properly sometimes #2150

Open
rfomin opened this issue Jan 25, 2025 · 7 comments
Open

A_RemoveFlags doesn't work properly sometimes #2150

rfomin opened this issue Jan 25, 2025 · 7 comments

Comments

@rfomin
Copy link
Collaborator

rfomin commented Jan 25, 2025

Bug report: [doomworld]
Test WAD: unfix_that.zip
From my tests, this WAD works differently in the latest versions of DSDA-Doom and Woof.
Works if revert 1d27148

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 25, 2025

I think the issue is size of this map, blockmap is 342x241.
See: https://github.com/kraflab/dsda-doom/blob/9980aed705d1fdddbdef3672f8ae806ce7c869e0/prboom2/src/p_setup.c#L3030-L3034

@fabiangreffrath
Copy link
Owner

The blockmap expansion code was requested to add in #759.

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 25, 2025

Not sure if this test map works at all. What is the maximum size of Doom map, unsigned short? Test map size is 43648x30768

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 25, 2025

I've made smaller version: unfix.zip
Now it works in DSDA-Doom 0.27.5 and Woof 14.5.0, but it does not work in the most recent versions.

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 25, 2025

@fabiangreffrath Do you know why we need 1d27148?

@fabiangreffrath
Copy link
Owner

This is the discussion behind it:

kraflab/dsda-doom#504

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 25, 2025

Thanks, I forgot. Hmm, so we do need a new comp_ flag after all? I wonder why test WAD doesn't work, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants