submit --force doesn't make all pushes force-pushes

[swolchok]

Through some sort of github user error (probably mine), a bunch of extra commits got added to one of my stacked PRs recently. I couldn't rebase and rerun ghstack --direct because the branches were out of sync. I was baffled as to why --force didn't resolve my issue, but it looks like it does something different? If this is an oversight, it could be fixed by adding force=self.force on

ghstack/ghstack/submit.py

Line 1533 in 6f32174

self._git_push(base_push_branches)

and

ghstack/ghstack/submit.py

Line 1535 in 6f32174

self._git_push(push_branches)

.

[ezyang]

Force does something different. We could also add an option to force Git pushes (or roll it into force)

[iwahbe]

Is this the appropriate issue to ask that that ghstack submit force pushes instead of adding an "Update" commit, or should I open a new issue for that?

[ezyang]

@iwahbe you're welcome to open issue, but not force pushing is an important part of ghstack's value proposition (as force pushing destroys preexisting PR comments in GitHub's UI)