Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Commit f065372

Browse files
author
stephaneDiot
committed
How to make a clean Pull Request
1 parent e32a5d1 commit f065372

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

CONTRIBUTING.md

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
### How to make a clean Pull Request:
2+
3+
1. Make sure your pull request has a correct title. For example in PlatformUI we use 'EZP-XXXXX: Title of the pull request'
4+
2. In the description of the pull request:
5+
⋅⋅* First add the JIRA link of your story.
6+
⋅⋅* Then add a short description about what's in the pull request.
7+
⋅⋅* Sometimes a screenshot, or a screencast is a good way to show your work.
8+
⋅⋅* Don't forget to mention if your code is tested (manual and unit tests, coverage...).
9+
3. Make a last check of the code you've just pushed, for example you can check:
10+
⋅⋅* The coding standard errors like empty lines or missing / added spaces
11+
⋅⋅* The naming. Begin you methods name by verbs (<verb>Something()). Try to be as descriptive as possible for your variables' name.
12+
⋅⋅* Make sure all you methods are commented with up to date parameters and visibility of your methods
13+
⋅⋅* Verify you don't have uneeded diff.
14+
4. Check if ezrobot and Travis are ok.
15+
5. Good job! You can now request a review!

0 commit comments

Comments
 (0)