This repository was archived by the owner on May 3, 2022. It is now read-only.
File tree 1 file changed +15
-0
lines changed
1 file changed +15
-0
lines changed Original file line number Diff line number Diff line change
1
+ ### How to make a clean Pull Request:
2
+
3
+ 1 . Make sure your pull request has a correct title. For example in PlatformUI we use 'EZP-XXXXX: Title of the pull request'
4
+ 2 . In the description of the pull request:
5
+ ⋅⋅* First add the JIRA link of your story.
6
+ ⋅⋅* Then add a short description about what's in the pull request. If it's a bugfix explain why and how it fixes the issue.
7
+ ⋅⋅* Sometimes a screenshot, or a screencast is a good way to show your work.
8
+ ⋅⋅* Don't forget to mention if your code is tested (manual and unit tests, coverage...).
9
+ 3 . Make a last check of the code you've just pushed, for example you can check again:
10
+ ⋅⋅* The coding standard errors like empty lines or missing / added spaces
11
+ ⋅⋅* The naming. Begin you methods name by verbs (<verb >Something()). Try to be as descriptive as possible for your variables' name.
12
+ ⋅⋅* Make sure all you methods are commented with up to date parameters and visibility of your methods
13
+ ⋅⋅* Verify you don't have uneeded diff.
14
+ 4 . Check if ezrobot and Travis are ok.
15
+ 5 . Good job! You can now request a review!
You can’t perform that action at this time.
0 commit comments