reformatted code

Author: Gareth Deli

DeeplTranslate/dtranslate_text_to_xml.py

@@ -43,20 +43,20 @@ def load_translations(self, translations_filename):
         file.close()
         return translations
 
-    def load_base_xml_file(self, xmlTemplateFilename):
+    def load_base_xml_file(self, xml_template_filename):
         # cparser = ET.XMLParser(target = CommentedTreeBuilder())
 
         # def read_xml_file(f):
         # return ET.parse(f, parser=cparser)
 
         # prepare things
         # tree = ET.parse(XMLINFILE)
-        # xml_tree = read_xml_file(xmlTemplateFilename)
-        xml_tree = ET.parse(xmlTemplateFilename)
+        # xml_tree = read_xml_file(xml_template_filename)
+        xml_tree = ET.parse(xml_template_filename)
         return xml_tree
 
-    def merge_translations(self, xmlFileRoot, translations):
-        xml_root = xmlFileRoot.getroot()
+    def merge_translations(self, xml_file_root, translations):
+        xml_root = xml_file_root.getroot()
         # translation_lines=len(translations)-1
         for i in range(len(xml_root)):
             is_translatable = xml_root[i].get('translatable')
@@ -95,13 +95,13 @@ def get_next_translation(self, translations):
                 # Now loop until this translation is ended
                 current_line = translations[self.currentIdx]
                 match = self.newTranslationStartPattern.match(current_line)
-                while ((match is None) & (self.currentIdx < len(translations))):
+                while (match is None) & (self.currentIdx < len(translations)):
                     self.currentIdx += 1
-                    if (not multi_line):
+                    if not multi_line:
                         this_translation += '\n'
                     this_translation += current_line
                     multi_line = True
-                    if (self.currentIdx < len(translations)):
+                    if self.currentIdx < len(translations):
                         current_line = translations[self.currentIdx]
                         match = self.newTranslationStartPattern.match(current_line)
                         # print('translation continues: ')

DeeplTranslate/dtranslate_xml_to_text.py

@@ -6,10 +6,10 @@
 import sys
 
 
-def extract_text_from_file(inputXmlFilename, outputTextFilename):
-    tree = ET.parse(inputXmlFilename)
+def extract_text_from_file(input_xml_filename, output_text_filename):
+    tree = ET.parse(input_xml_filename)
     root = tree.getroot()
-    file = open(outputTextFilename, 'w')
+    file = open(output_text_filename, 'w')
 
     counter = 0
 
@@ -24,7 +24,7 @@ def extract_text_from_file(inputXmlFilename, outputTextFilename):
                     counter = counter + 1
                     file.write(str(counter) + ':' + root[i][j].text + '\n')
     file.close()
-    print('Text extracted to ', outputTextFilename)
+    print('Text extracted to ', output_text_filename)
 
 
 # ------------------------------------------------------------------------------

GoogleTranslate/gtranslate.py

@@ -192,29 +192,29 @@ def translate(self, to_translate, from_language="auto", to_language="auto"):
         return parsed3
 
 
-    def translate_xml_file(self, inFile, out_file, fromLanguage, toLanguage):
+    def translate_xml_file(self, inFile, out_file, from_language, to_language):
         tree = ET.parse(inFile)
         root = tree.getroot()
         for i in range(len(root)):
             is_translatable = root[i].get('translatable')
             if root[i].tag == 'string':
                 if is_translatable != 'false':
-                    totranslate = root[i].text
+                    to_translate = root[i].text
                     print((str(i) + " ========================="))
-                    print(totranslate)
+                    print(to_translate)
                     print("-->")
-                    if (totranslate != None):
-                        root[i].text = self.translate(totranslate, fromLanguage, toLanguage)
+                    if to_translate is not None:
+                        root[i].text = self.translate(to_translate, from_language, to_language)
                         print(root[i].text)
             elif root[i].tag == 'string-array':
                 if is_translatable != 'false':
                     for j in range(len(root[i])):
                         if root[i][j].tag == 'item':
-                            totranslate = root[i][j].text
-                            if totranslate != None:
-                                root[i][j].text = self.translate(totranslate, fromLanguage, toLanguage)
+                            to_translate = root[i][j].text
+                            if to_translate is not None:
+                                root[i][j].text = self.translate(to_translate, from_language, to_language)
                                 print((str(i) + "[" + str(j) + "] ========================="))
-                                print(totranslate)
+                                print(to_translate)
                                 print(root[i][j].text)
         print('writing to ' + out_file)
         tree.write(out_file, xml_declaration=True, encoding='utf-8')