Skip to content

Support for Brotli compression #71

@joostdebruijn

Description

@joostdebruijn

Is it an idea to add Brotli compression for https-requests to this module? Now support for Brotli has landed in the developer channels of Firefox and Chrome it is very likely that a significantly amount of clients will have support for this enabled in the very near future. So, it is maybe a good idea to support it in this module too.

I’m not (yet) very experienced with building modules for Node, but if there is anything I can help with, please let me know.

Activity

dougwilson

dougwilson commented on Jan 24, 2016

@dougwilson
Contributor

Hi! This was discussed before in #59 if you want to read the prior discussion.

The answer is that we certainly can, but for it to be built-in here, we need the support either added to Node.js core or a pure-JS library.

Barring that, another option is to make this module flexible and allow for alternative user-defined encodings. There was the PR #62 but it was never completed due to a disagreement between the author and myself over a feature I wanted to be supported.

self-assigned this
on Jan 24, 2016
dantman

dantman commented on Feb 1, 2016

@dantman

The performance of brotli is something that should be kept in mind.

Some previous tests:

brotli isn't necessarily always more efficient than gzip. brotli's biggest advantage is that at higher compression levels, at the cost of compression time, you can get compression ratios beyond what you can do even by using zopfli.

So you don't really get an advantage from using zopfli or brotli for dynamic content. They work best when you can wait a few extra seconds to let the compressor do more work.

For most people this means making a .gz file (using zopfli) and a .bro file with brotli during your build step and using the pre-compressed files instead of dynamically compressing with either.

LeandroFavero

LeandroFavero commented on Feb 12, 2016

@LeandroFavero

dougwilson, maybe this can help:
A JavaScript port of the Brotli compression algorithm
https://github.com/devongovett/brotli.js

passcod

passcod commented on May 25, 2016

@passcod

Note that the above port of Brotli doesn't support streaming yet. People interested in brotli and zopfli in the meantime may want to have a look at https://github.com/aickin/shrink-ray.

mikemaccana

mikemaccana commented on Apr 4, 2017

@mikemaccana

@dantman At level 4, Brotli uses less CPU AND compresses better than gzip - here's the results of a test using the top 1000 URLs on the internet: https://blogs.akamai.com/2016/02/understanding-brotlis-potential.html

dougwilson

dougwilson commented on Mar 11, 2018

@dougwilson
Contributor

It looks like Node.js is discussing adding support ad a built-in nodejs/node#18964 which should make it trivial to add to this module.

yocontra

yocontra commented on Dec 18, 2018

@yocontra

This library supports streaming - https://github.com/MayhemYDG/iltorb#stream (native package though, maybe make it an optional dep?)

If the maintainers are interested I can send a PR, let me know.

voxpelli

voxpelli commented on Jan 7, 2019

@voxpelli

Built in support in Node landed 2 days ago: nodejs/node#24938

6 remaining items

patrickmichalina

patrickmichalina commented on Jun 7, 2019

@patrickmichalina

I submitted a PR #156 since there was not progress on the other one.

KB1RMA

KB1RMA commented on Aug 7, 2019

@KB1RMA

Is there any reason Patrick's PR from above is still waiting for a merge? I'm running on 10.16 at the moment and would love to be able to turn brotli on - I can't see anything obvious holding up the release of that option via the PR.

dougwilson

dougwilson commented on Aug 7, 2019

@dougwilson
Contributor

It seems like a duplicate of #150 and doesn't even address the issues that were brought up in that issue.

KB1RMA

KB1RMA commented on Aug 10, 2019

@KB1RMA

Ah I missed that PR, sorry. Looks like it addresses the testing well but not the options.

patrickmichalina

patrickmichalina commented on Sep 9, 2019

@patrickmichalina

I can look into the options portion as well.

deleted a comment from cupcakearmy on May 21, 2020
nicksrandall

nicksrandall commented on Sep 15, 2020

@nicksrandall
Contributor

Yet another PR #173

mridang

mridang commented on Sep 3, 2024

@mridang

Hi everyone. 👋🏼 It's been a god couple of years since the last comment on this thread so I'm just checking if this still slated to be done? I would hate to run off a fork. Of course, if there ways I can contribute, happy to do this. Both #172 and #173 seem to be in limbo. Thank you

Kikobeats

Kikobeats commented on Sep 3, 2024

@Kikobeats

I resolved this creating a standalone package: https://github.com/Kikobeats/http-compression
Working with no issues from a year.

bjohansebas

bjohansebas commented on Jan 8, 2025

@bjohansebas
Member

Fixed by #194

Thanks to each person who opened PRs and those who participated in them to make this feature happen. Every discussion that took place helped make it possible to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @voxpelli@dantman@dougwilson@passcod@mikemaccana

    Issue actions

      Support for Brotli compression · Issue #71 · expressjs/compression