Skip to content

Commit d7bb81b

Browse files
committed
tests: fix backpressure tests
1 parent cd957aa commit d7bb81b

File tree

1 file changed

+23
-8
lines changed

1 file changed

+23
-8
lines changed

test/compression.js

+23-8
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,15 @@ describe('compression()', function () {
158158
it('should back-pressure when compressed', function (done) {
159159
var buf
160160
var client
161-
var drained = false
161+
var drained = []
162162
var resp
163163
var server = createServer({ threshold: 0 }, function (req, res) {
164164
resp = res
165+
165166
res.on('drain', function () {
166-
drained = true
167+
drained.push('first')
167168
})
169+
168170
res.setHeader('Content-Type', 'text/plain')
169171
res.write('start')
170172
pressure()
@@ -179,7 +181,11 @@ describe('compression()', function () {
179181

180182
function complete () {
181183
if (--wait !== 0) return
182-
assert.ok(drained)
184+
assert.deepEqual(drained, [
185+
'first',
186+
'second',
187+
'true'
188+
])
183189
done()
184190
}
185191

@@ -191,9 +197,11 @@ describe('compression()', function () {
191197
}
192198

193199
resp.on('drain', function () {
194-
resp.write('end')
200+
drained.push('second')
201+
drained.push(String(resp.write('end')))
195202
resp.end()
196203
})
204+
197205
resp.on('finish', complete)
198206
client.resume()
199207
}
@@ -214,13 +222,15 @@ describe('compression()', function () {
214222
it('should back-pressure when uncompressed', function (done) {
215223
var buf
216224
var client
217-
var drained = false
225+
var drained = []
218226
var resp
219227
var server = createServer({ filter: function () { return false } }, function (req, res) {
220228
resp = res
229+
221230
res.on('drain', function () {
222-
drained = true
231+
drained.push('first')
223232
})
233+
224234
res.setHeader('Content-Type', 'text/plain')
225235
res.write('start')
226236
pressure()
@@ -235,7 +245,11 @@ describe('compression()', function () {
235245

236246
function complete () {
237247
if (--wait !== 0) return
238-
assert.ok(drained)
248+
assert.deepEqual(drained, [
249+
'first',
250+
'second',
251+
'true'
252+
])
239253
done()
240254
}
241255

@@ -247,7 +261,8 @@ describe('compression()', function () {
247261
}
248262

249263
resp.on('drain', function () {
250-
resp.write('end')
264+
drained.push('second')
265+
drained.push(String(resp.write('end')))
251266
resp.end()
252267
})
253268
resp.on('finish', complete)

0 commit comments

Comments
 (0)