Implemented the Linked List exercise #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started with the Go track and they had more tests than required so I went ahead and implemented these. There were also exception raised for `pop()` and `shift()` on empty list but no tests for that (in problem-description as well as in the Go track) so I added these too.
Based on the title, I misinterpreted the tests ending in `_reassigns_head` and `_reassigns_tail`. I got it straight after a discussion in the forum (doesnt-understand-the-following-tests/20050).
glennj
requested changes
Nov 26, 2025
Comment on lines
+13
to
+14
| Cannot_Shift_empty_List, | ||
| Cannot_Pop_Empty_List, |
Contributor
There was a problem hiding this comment.
Do we need separate errors for these operations?
Suggested change
| Cannot_Shift_empty_List, | |
| Cannot_Pop_Empty_List, | |
| Empty_List, |
Contributor
Author
There was a problem hiding this comment.
Great suggestion. Will do.
Merged
Contributor
Author
|
I corrupted my local copy somehow. Resubmitted as #90 with suggested changes of merging errors into a single Empty_List error. |
rmonnet
added a commit
that referenced
this pull request
Nov 27, 2025
Replacement for PR #87. * Implemented the Linked List exercise I started with the Go track and they had more tests than required so I went ahead and implemented these. There were also exception raised for `pop()` and `shift()` on empty list but no tests for that (in problem-description as well as in the Go track) so I added these too. * Fix two exercises that I misunderstood Based on the title, I misinterpreted the tests ending in `_reassigns_head` and `_reassigns_tail`. I got it straight after a discussion in the forum (doesnt-understand-the-following-tests/20050). * SImplify error handling Replaced multiple errors with a simpler Empty_List one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with the Go track and they had more tests than required so I went ahead and implemented these.
There were also exception raised for
pop()andshift()on empty list but no tests for that (in problem-description as well as in the Go track) so I added these too.