Skip to content

Commit beb0c66

Browse files
authored
matching-brackets: Explicitly check with true? in tests (#700)
* update starter file * explicitly check for `true` in tests * update config * rename test functions, make test descriptions identical to the ones from .toml
1 parent b866e68 commit beb0c66

File tree

3 files changed

+53
-51
lines changed

3 files changed

+53
-51
lines changed

exercises/practice/matching-brackets/.meta/config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"AndreaCrotti",
77
"haus",
88
"sjwarner-bp",
9-
"yurrriq"
9+
"yurrriq",
10+
"tasxatzial"
1011
],
1112
"files": {
1213
"solution": [
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
(ns matching-brackets)
22

3-
(defn valid? [] ;; <- arglist goes here
4-
;; your code goes here
5-
)
3+
(defn valid?
4+
[s]
5+
;; function body
6+
)

exercises/practice/matching-brackets/test/matching_brackets_test.clj

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -2,82 +2,82 @@
22
(:require [clojure.test :refer [deftest testing is]]
33
matching-brackets))
44

5-
(deftest paired-square-brackets
5+
(deftest valid?_test_1
66
(testing "paired square brackets"
7-
(is (matching-brackets/valid? "[]"))))
7+
(is (true? (matching-brackets/valid? "[]")))))
88

9-
(deftest empty-string
10-
(testing "Empty string"
11-
(is (matching-brackets/valid? ""))))
9+
(deftest valid?_test_2
10+
(testing "empty string"
11+
(is (true? (matching-brackets/valid? "")))))
1212

13-
(deftest unpaired-brackets
14-
(testing "Unpaired brackets"
13+
(deftest valid?_test_3
14+
(testing "unpaired brackets"
1515
(is (false? (matching-brackets/valid? "[[")))))
1616

17-
(deftest wrong-ordered-brackets
18-
(testing "Wrong ordered brackets"
17+
(deftest valid?_test_4
18+
(testing "wrong ordered brackets"
1919
(is (false? (matching-brackets/valid? "}{")))))
2020

21-
(deftest wrong-closing-bracket
22-
(testing "Wrong closing bracket"
21+
(deftest valid?_test_5
22+
(testing "wrong closing bracket"
2323
(is (false? (matching-brackets/valid? "{]")))))
2424

25-
(deftest paired-with-whitespace
26-
(testing "Paired with whitespace"
27-
(is (matching-brackets/valid? "{ }"))))
25+
(deftest valid?_test_6
26+
(testing "paired with whitespace"
27+
(is (true? (matching-brackets/valid? "{ }")))))
2828

29-
(deftest partially-paired-brackets
30-
(testing "Partially paired brackets"
29+
(deftest valid?_test_7
30+
(testing "partially paired brackets"
3131
(is (false? (matching-brackets/valid? "{[])")))))
3232

33-
(deftest simple-nested-brackets
34-
(testing "Simple nested brackets"
35-
(is (matching-brackets/valid? "{[]}"))))
33+
(deftest valid?_test_8
34+
(testing "simple nested brackets"
35+
(is (true? (matching-brackets/valid? "{[]}")))))
3636

37-
(deftest several-paired-brackets
38-
(testing "Several paired brackets"
39-
(is (matching-brackets/valid? "{}[]"))))
37+
(deftest valid?_test_9
38+
(testing "several paired brackets"
39+
(is (true? (matching-brackets/valid? "{}[]")))))
4040

41-
(deftest paired-and-nested-brackets
42-
(testing "Paired and nested brackets"
43-
(is (matching-brackets/valid? "([{}({}[])])"))))
41+
(deftest valid?_test_10
42+
(testing "paired and nested brackets"
43+
(is (true? (matching-brackets/valid? "([{}({}[])])")))))
4444

45-
(deftest unopened-closing-brackets
46-
(testing "Unopened closing brackets"
45+
(deftest valid?_test_11
46+
(testing "unopened closing brackets"
4747
(is (false? (matching-brackets/valid? "{[)][]}")))))
4848

49-
(deftest unpaired-and-nested-brackets
50-
(testing "Unpaired and nested brackets"
49+
(deftest valid?_test_12
50+
(testing "unpaired and nested brackets"
5151
(is (false? (matching-brackets/valid? "([{])")))))
5252

53-
(deftest paired-and-wrong-nested-brackets
54-
(testing "Paired and wrong nested brackets"
53+
(deftest valid?_test_13
54+
(testing "paired and wrong nested brackets"
5555
(is (false? (matching-brackets/valid? "[({]})")))))
5656

57-
(deftest paired-and-wrong-nested-brackets-but-innermost-are-correct
58-
(testing "Paired and wrong nested brackets but innermost are correct"
57+
(deftest valid?_test_14
58+
(testing "paired and wrong nested brackets but innermost are correct"
5959
(is (false? (matching-brackets/valid? "[({}])")))))
6060

61-
(deftest paired-and-incomplete-brackets
62-
(testing "Paired and incomplete brackets"
61+
(deftest valid?_test_15
62+
(testing "paired and incomplete brackets"
6363
(is (false? (matching-brackets/valid? "{}[")))))
6464

65-
(deftest too-many-closing-brackets
66-
(testing "Too many closing brackets"
65+
(deftest valid?_test_16
66+
(testing "too many closing brackets"
6767
(is (false? (matching-brackets/valid? "[]]")))))
6868

69-
(deftest early-unexpected-brackets
70-
(testing "Early unexpected brackets"
69+
(deftest valid?_test_17
70+
(testing "early unexpected brackets"
7171
(is (false? (matching-brackets/valid? ")()")))))
7272

73-
(deftest early-mismatched-brackets
74-
(testing "Early mismatched brackets"
73+
(deftest valid?_test_18
74+
(testing "early mismatched brackets"
7575
(is (false? (matching-brackets/valid? "{)()")))))
7676

77-
(deftest math-expression
78-
(testing "Math expression"
79-
(is (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2"))))
77+
(deftest valid?_test_19
78+
(testing "math expression"
79+
(is (true? (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2")))))
8080

81-
(deftest complex-latex-expression
82-
(testing "Complex latex expression"
83-
(is (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)"))))
81+
(deftest valid?_test_20
82+
(testing "complex latex expression"
83+
(is (true? (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)")))))

0 commit comments

Comments
 (0)