Skip to content

Commit 10e240a

Browse files
committed
Fixed an issue with aspire minio storage implementation.
1 parent 1b8d6aa commit 10e240a

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/Exceptionless.AppHost/Extensions/MinIoExtensions.cs

+5-4
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public static IResourceBuilder<MinIoResource> AddMinIo(
2626
var storage = new S3FileStorage(o => o.ConnectionString(connectionString));
2727
try
2828
{
29-
storage.Client.PutBucketAsync(options.Bucket ?? "storage", ct).GetAwaiter().GetResult();
29+
await storage.Client.PutBucketAsync(options.Bucket ?? "storage", ct);
3030
}
3131
catch
3232
{
@@ -85,10 +85,11 @@ public class MinIoResource(string name, string? accessKey = null, string? secret
8585

8686
public ReferenceExpression ConnectionStringExpression =>
8787
ReferenceExpression.Create(
88-
$"ServiceUrl=http://{ApiEndpoint.Property(EndpointProperty.Host)}:{ApiEndpoint.Property(EndpointProperty.Port)};" +
88+
$"EndPoint=http://{ApiEndpoint.Property(EndpointProperty.Host)}:{ApiEndpoint.Property(EndpointProperty.Port)};" +
8989
$"AccessKey={AccessKey ?? "minioadmin"};" +
9090
$"SecretKey={SecretKey ?? "minioadmin"};" +
91-
$"Bucket={Bucket}");
91+
$"Bucket={Bucket};" +
92+
$"Provider=minio;");
9293

9394
public string? AccessKey { get; } = accessKey;
9495
public string? SecretKey { get; } = secretKey;
@@ -135,5 +136,5 @@ internal static class MinIoContainerImageTags
135136
{
136137
internal const string Registry = "docker.io";
137138
internal const string Image = "minio/minio";
138-
internal const string Tag = "RELEASE.2024-12-13T22-19-12Z";
139+
internal const string Tag = "RELEASE.2025-04-22T22-12-26Z";
139140
}

src/Exceptionless.Core/Configuration/StorageOptions.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static StorageOptions ReadFromConfiguration(IConfiguration config, AppOpt
2727
}
2828
else
2929
{
30-
var minioConnectionString = config.GetConnectionString("S3");
30+
string? minioConnectionString = config.GetConnectionString("S3");
3131
if (!String.IsNullOrEmpty(minioConnectionString))
3232
{
3333
options.Provider = "s3";

0 commit comments

Comments
 (0)