Skip to content

Commit a242df6

Browse files
author
aliakseiTraihel
committed
[ELI_60] Review refactoring.
1 parent 8ad2231 commit a242df6

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

core/src/main/java/com/exadel/etoolbox/linkinspector/core/services/data/impl/DataFeedServiceImpl.java

+9-7
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
public class DataFeedServiceImpl implements DataFeedService {
6161
private static final Logger LOG = LoggerFactory.getLogger(DataFeedServiceImpl.class);
6262

63-
private static final CopyOnWriteArrayList<GridResource> GRID_RESOURCE_COPY_ON_WRITE_ARRAY_LIST = new CopyOnWriteArrayList<>();
63+
private final CopyOnWriteArrayList<GridResource> GRID_RESOURCE = new CopyOnWriteArrayList<>();
6464

6565
@Reference
6666
private RepositoryHelper repositoryHelper;
@@ -197,16 +197,18 @@ public void deleteDataFeed() throws DataFeedException {
197197
}
198198

199199
private List<GridResource> getGridResourcesList() {
200-
return new ArrayList<>(GRID_RESOURCE_COPY_ON_WRITE_ARRAY_LIST);
200+
return GRID_RESOURCE;
201201
}
202202

203-
private synchronized void setGridResourcesList(List<GridResource> gridResources) {
204-
GRID_RESOURCE_COPY_ON_WRITE_ARRAY_LIST.clear();
205-
GRID_RESOURCE_COPY_ON_WRITE_ARRAY_LIST.addAll(gridResources);
203+
private void setGridResourcesList(List<GridResource> gridResources) {
204+
synchronized (this) {
205+
GRID_RESOURCE.clear();
206+
GRID_RESOURCE.addAll(gridResources);
207+
}
206208
}
207209

208-
private synchronized void clearStaticDataFeed() {
209-
GRID_RESOURCE_COPY_ON_WRITE_ARRAY_LIST.clear();
210+
private void clearStaticDataFeed() {
211+
GRID_RESOURCE.clear();
210212
}
211213

212214
private List<GridResource> dataFeedToGridResources(ResourceResolver resourceResolver) {

0 commit comments

Comments
 (0)