Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly handle error, when .install isn't executable #21

Open
gverilla opened this issue Aug 17, 2015 · 2 comments
Open

Explicitly handle error, when .install isn't executable #21

gverilla opened this issue Aug 17, 2015 · 2 comments

Comments

@gverilla
Copy link

Currently, when an .install-script that isn't executable is to be executed, the application fails with a cryptic:

[Errno 13]: Permission denied

(which is what subprocess.Popen throws here, when it can't run a script) That's a terrible error message to debug.

Instead I'd suggest to handle it either by a) attempting to chmod +x it manually or by b) exiting with a message that explains what script caused the error.

@gverilla gverilla reopened this Aug 17, 2015
@gverilla
Copy link
Author

I just send you a PR for the "exiting with an explanation"-scenario.

@countsudoku
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants