Skip to content

Commit d717362

Browse files
committed
Revert "ENH: More uint types for torch"
This reverts commit c787bea. PyTorch support for unsigned ints is patchy, as of pytorch 2.6 at least. See data-apis#253 (comment) for a discussion.
1 parent 84390f5 commit d717362

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

array_api_compat/torch/_aliases.py

-6
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,6 @@
3131
torch.int32,
3232
torch.int64,
3333
}
34-
try:
35-
# torch >=2.3
36-
_int_dtypes |= {torch.uint16, torch.uint32, torch.uint64}
37-
except AttributeError:
38-
pass
39-
4034

4135
_array_api_dtypes = {
4236
torch.bool,

torch-xfails.txt

+12
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,23 @@ array_api_tests/test_array_object.py::test_getitem
88
array_api_tests/test_array_object.py::test_setitem
99
# Masking doesn't suport 0 dimensions in the mask
1010
array_api_tests/test_array_object.py::test_getitem_masking
11+
# torch doesn't have uint dtypes other than uint8
12+
array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint16)]
13+
array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint32)]
14+
array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint64)]
15+
array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint16)]
16+
array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint32)]
17+
array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint64)]
1118

1219
# Overflow error from large inputs
1320
array_api_tests/test_creation_functions.py::test_arange
1421
# pytorch linspace bug (should be fixed in torch 2.0)
1522

23+
# torch doesn't have higher uint dtypes
24+
array_api_tests/test_data_type_functions.py::test_iinfo[uint16]
25+
array_api_tests/test_data_type_functions.py::test_iinfo[uint32]
26+
array_api_tests/test_data_type_functions.py::test_iinfo[uint64]
27+
1628
# We cannot wrap the tensor object
1729
array_api_tests/test_has_names.py::test_has_names[array_method-__array_namespace__]
1830
array_api_tests/test_has_names.py::test_has_names[array_method-to_device]

0 commit comments

Comments
 (0)