Remove support for findstr

findstr is a broken program; I can't get it to work outside of EasyGrep. I'd
rather spend my time on better search tools than it.

Author: dkprice

plugin/EasyGrep.vim

@@ -2050,6 +2050,7 @@ function! s:ValidateGrepCommand()
     let commandParams = s:GetGrepCommandParameters()
     if empty(commandParams)
         call s:Error("Cannot proceed; the configured 'grepprg' setting is not a known program")
+        call s:Error("Select a supported program with :GrepProgram")
         return 0
     endif
 
@@ -2685,28 +2686,28 @@ function! s:ConfigureGrepCommandParameters()
                 \ 'opt_bool_isselffiltering': '1',
                 \ })
 
-    call s:RegisterGrepProgram("findstr", {
-                \ 'req_str_programargs': '/n',
-                \ 'req_bool_supportsexclusions': '0',
-                \ 'req_str_recurse': '/S',
-                \ 'req_str_caseignore': '/I',
-                \ 'req_str_casematch': '',
-                \ 'opt_str_warnonuse': 'The findstr program is buggy and not-recommended for use',
-                \ 'opt_str_patternprefix': '',
-                \ 'opt_str_patternpostfix': '',
-                \ 'opt_str_wholewordprefix': '"\<',
-                \ 'opt_str_wholewordpostfix': '\>"',
-                \ 'opt_str_wholewordoption': '',
-                \ 'req_str_escapespecialcharacters': "\^$#.*",
-                \ 'opt_str_escapespecialcharacterstwice': "",
-                \ 'opt_str_mapexclusionsexpression': '',
-                \ 'opt_bool_filtertargetswithnofiles': '1',
-                \ 'opt_bool_bufferdirsearchallowed': '1',
-                \ 'opt_str_suppresserrormessages': '',
-                \ 'opt_bool_directoryneedsbackslash': '1',
-                \ 'opt_bool_isinherentlyrecursive': '0',
-                \ 'opt_bool_isselffiltering': '0',
-                \ })
+    "call s:RegisterGrepProgram("findstr", {
+                "\ 'req_str_programargs': '/n',
+                "\ 'req_bool_supportsexclusions': '0',
+                "\ 'req_str_recurse': '/S',
+                "\ 'req_str_caseignore': '/I',
+                "\ 'req_str_casematch': '',
+                "\ 'opt_str_warnonuse': 'The findstr program is buggy and not-recommended for use',
+                "\ 'opt_str_patternprefix': '',
+                "\ 'opt_str_patternpostfix': '',
+                "\ 'opt_str_wholewordprefix': '"\<',
+                "\ 'opt_str_wholewordpostfix': '\>"',
+                "\ 'opt_str_wholewordoption': '',
+                "\ 'req_str_escapespecialcharacters': "\^$#.*",
+                "\ 'opt_str_escapespecialcharacterstwice': "",
+                "\ 'opt_str_mapexclusionsexpression': '',
+                "\ 'opt_bool_filtertargetswithnofiles': '1',
+                "\ 'opt_bool_bufferdirsearchallowed': '1',
+                "\ 'opt_str_suppresserrormessages': '',
+                "\ 'opt_bool_directoryneedsbackslash': '1',
+                "\ 'opt_bool_isinherentlyrecursive': '0',
+                "\ 'opt_bool_isselffiltering': '0',
+                "\ })
 endfunction
 " }}}
 " GetGrepCommandParameters {{{

tests/casesensitivity_findstr.ok renamed to tests/archive/casesensitivity_findstr.ok

@@ -2,39 +2,34 @@
 # casesensitivity
 casesensitivity_ack.vim
 casesensitivity_ag.vim
-casesensitivity_findstr.vim
 casesensitivity_grep.vim
 casesensitivity_pt.vim
 casesensitivity_vimgrep.vim
 
 # wholeword
 wholeword_ack.vim
 wholeword_ag.vim
-wholeword_findstr.vim
 wholeword_grep.vim
 wholeword_pt.vim
 wholeword_vimgrep.vim
 
 # exclusions
 exclusions_ack.vim
 exclusions_ag.vim
-# exclusions_findstr.vim # not yet supported
 exclusions_grep.vim
 # exclusions_pt.vim      # not yet supported
 exclusions_vimgrep.vim
 
 # recursion
 recursion_ack.vim
 recursion_ag.vim
-recursion_findstr.vim
 recursion_grep.vim
 # recursion_pt.vim # disabled; output is non-deterministic
 recursion_vimgrep.vim
 
 # simpleregex
 simpleregex_ack.vim
 simpleregex_ag.vim
-# simpleregex_findstr.vim # findstr is broken; it does not search character classes correctly
 simpleregex_grep.vim
 simpleregex_pt.vim
 simpleregex_vimgrep.vim