Skip to content

Conversation

@junderw
Copy link

@junderw junderw commented Dec 4, 2020

Fixes #1 and also adds tests for the 2 missing branches (unrelated to this PR) so now coverage is 100% across the board.

@junderw
Copy link
Author

junderw commented Dec 4, 2020

oof... looks like the dependencies I pulled in are newer than master, so a large diff was created in the pre-commit build...

I'll try to find the version being used here.

@junderw
Copy link
Author

junderw commented Dec 4, 2020

ok, nvm. all dependencies are specific versions...

Not quite sure how to deal with the built source... Should I maybe just remove them?

This was installed + built using the following node versions btw:

$ node -v
v12.18.3
$ npm -v
6.14.8

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fc89e67 on junderw:fixToWei into 35d870e on ethjs:master.

@SilentCicero
Copy link
Member

Reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#toWei breaks for decimal inputs of "wei" and "noether"

3 participants