You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Within our tx package we have a TransactionCache object:
exportinterfaceTransactionCache{hash?: Uint8ArraydataFee?: {value: biginthardfork: string|Hardfork}senderPubKey?: Uint8Array// TODO: re-add these cache items for the JSON //accessListJSON?: AccessList//authorityListJSON?: AuthorizationList}
This is there, but it does not seem tested that well:
In particular, this should likely be the behavior: we should only cache if the tx object itself is frozen (as in Object.frozen. If it is not frozen, the values could change, and therefore the cache should be invalidated.
The accessListJSON and authorityListJSON should also be added in to cache these items when toJSON is called on the tx (or: we could also cache the resulting JSON object. If the tx object is frozen we can also freeze the resulting cached object!)
The text was updated successfully, but these errors were encountered:
Within our tx package we have a
TransactionCache
object:This is there, but it does not seem tested that well:
In particular, this should likely be the behavior: we should only cache if the tx object itself is frozen (as in
Object.frozen
. If it is not frozen, the values could change, and therefore the cache should be invalidated.The
accessListJSON
andauthorityListJSON
should also be added in to cache these items whentoJSON
is called on the tx (or: we could also cache the resulting JSON object. If the tx object is frozen we can also freeze the resulting cached object!)The text was updated successfully, but these errors were encountered: