Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves EOF tests from Prague to Osaka #15828

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Moves EOF tests from Prague to Osaka #15828

merged 1 commit into from
Feb 10, 2025
+22 −29

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Feb 4, 2025 •
edited by nikola-matic
Loading

Fixes #15622
Depends on #15830

@r0qs r0qs added the has dependencies The PR depends on other PRs that must be merged first label Feb 4, 2025
@r0qs r0qs marked this pull request as ready for review February 4, 2025 13:50
@r0qs r0qs mentioned this pull request Feb 4, 2025
Closed
@r0qs r0qs added the EOF label Feb 4, 2025
@r0qs r0qs requested review from cameel and clonker February 4, 2025 13:51
@r0qs r0qs changed the title Move EOF to Osaka Bump evmone to 0.13.0, add Osaka as a supported EVM version and move EOF to Osaka Feb 4, 2025
@r0qs r0qs marked this pull request as draft February 4, 2025 16:54
@r0qs r0qs changed the base branch from bump-evmone-13 to add-evm-version-osaka February 4, 2025 17:21
@r0qs r0qs changed the title Bump evmone to 0.13.0, add Osaka as a supported EVM version and move EOF to Osaka Moves EOF tests from Prague to Osaka Feb 4, 2025
@r0qs r0qs force-pushed the add-evm-version-osaka branch from 7473b22 to 1fa5cdf Compare February 6, 2025 01:13
@r0qs r0qs marked this pull request as ready for review February 6, 2025 01:14
@nikola-matic nikola-matic force-pushed the add-evm-version-osaka branch from 1fa5cdf to 94b94db Compare February 6, 2025 09:17
@nikola-matic nikola-matic force-pushed the add-evm-version-osaka branch from 94b94db to 9e9f40e Compare February 6, 2025 14:53
@cameel cameel mentioned this pull request Feb 6, 2025
Merged
@nikola-matic nikola-matic force-pushed the add-evm-version-osaka branch from 9e9f40e to 6b4ee52 Compare February 6, 2025 18:42
Base automatically changed from add-evm-version-osaka to develop February 7, 2025 06:50
@nikola-matic nikola-matic force-pushed the move-eof-osaka branch 2 times, most recently from 9366f04 to 9a29bdf Compare February 7, 2025 11:57
cameel
cameel reviewed Feb 7, 2025
View reviewed changes
.circleci/soltest_all.sh
@@ -32,7 +32,7 @@ REPODIR="$(realpath "$(dirname "$0")"/..)"
source "${REPODIR}/scripts/common.sh"

DEFAULT_EVM_VALUES=(constantinople petersburg istanbul berlin london paris shanghai cancun prague osaka)
EVMS_WITH_EOF=(prague)
EVMS_WITH_EOF=(osaka)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it, we should have changed it to (prague osaka) in #15830 because otherwise we're missing a test run for --evm-version 1 --evm-version osaka. Not a big deal, since this PR should go in very soon anyway, but I thought I'd mention it because it looks like something that's easy to overlook when adding a new EVM version.

Maybe we should just define the first EVM version with EOF here and calculate the list by slicing the list above? Then we would not have to update it ever again.

On the other hand slicing will probably be annoying to do in Bash :)

Copy link
Collaborator

@nikola-matic nikola-matic Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added firstWithEOF(); gonna omit the bash slicing though. Unless you were referring to adding a first with EOF in here as well (soltest_all)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if we did the slicing, we'd only need a variable that would indicate where to slice (i.e. which was the first EVM version with EOF).

But anyway, it's ok. I'm not sure myself if this would be good change. Both solutions have downsides so we can leave it as is for the time being.

@nikola-matic nikola-matic removed the has dependencies The PR depends on other PRs that must be merged first label Feb 10, 2025
@nikola-matic nikola-matic requested a review from cameel February 10, 2025 10:00
@nikola-matic nikola-matic merged commit c315294 into develop Feb 10, 2025
74 checks passed
@nikola-matic nikola-matic deleted the move-eof-osaka branch February 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

@nikola-matic nikola-matic nikola-matic left review comments

@clonker clonker Awaiting requested review from clonker

Assignees
No one assigned
Labels
EOF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump evmone to 0.13.0 and define Osaka as a supported EVM version
3 participants
@r0qs @cameel @nikola-matic