-
Notifications
You must be signed in to change notification settings - Fork 435
Switch docs back to openrpc
v2
#667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Docusaurus
Co-authored-by: lightclient <[email protected]>
Co-authored-by: lightclient <[email protected]>
update openrpc to v2
edit after build add contents write add path-prefix use peaceiris rework install setup rebuild gatsby again update config and deployment Add actions bot back to peace iris
We should be sure to squash all this to one commit if/when merged. |
So the speccheck -v is failing not your fault but from the rpctestgen it has to do with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall looks good jsut a few things around the package use and CI that will clean things up. I also had a qustion about using mjs in this repo for the most part. Generator uses the .js here but I think maybe there's an opp to switch back to mjs as it'll be more future proof. I'll test this when I bump the generator version
uses: peaceiris/actions-gh-pages@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be cool if we could stay on actions I think for long term usability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here. Can you clarify?
package.json
Outdated
"lint": "npm run build:spec && node scripts/validate.mjs && node scripts/graphql-validate.mjs", | ||
"build:spec": "node scripts/build.js", | ||
"build:docs": "npm run generate-clients && npm run build:docs:gatsby", | ||
"build:docs:gatsby": "cp docs/config/gatsby-config.js build/docs/gatsby && cd build/docs/gatsby && npm install && gatsby build --prefix-paths", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be cleaned up via the generator changes that will allow you to spec paths in the config.json
siteUrl: process.env.GITHUB_REPOSITORY | ||
? `https://${process.env.GITHUB_REPOSITORY.split('/')[0]}.github.io/execution-apis` | ||
: 'https://ethereum.github.io/execution-apis', // fallback for local development | ||
logoUrl: 'https://raw.githubusercontent.com/open-rpc/design/master/icons/open-rpc-logo-noText/open-rpc-logo-noText%20(PNG)/256x256.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's an eth icon or one for execution apis we might drop that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @bomanaps mentioned it earlier there seems to be a formatting issue with the markdown table here. We might consider switching to .mdx to give these a little more spacing or container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be but that's really beyond the scope of this PR (which is intended to be isolated to migrating back to OpenRPC generator). Ideally that sort of stuff would be addressed separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take a look at this @zcstarr acolytec3#5
This change allows for documentation assets to be copied by the generator into the proper build locations, eliminating the need for manual copy.
update support for latest generator
Just noticed there were still merge conflicts. Will clean them up. |
Trying to run this locally, but it fails to generate with node version 22.17.0.
|
Can you document what steps you use to hit this issue? I deleted
And everything compiles and build on node 22.17.0. |
This replaces the #653 docs project with the OpenRPC v2 docs generator so reverts back to the Gatsby build for now, based on #660.
Major changes
gatsby-config
that is copied to gatsby build and adds menu items for our docstests/README.md
todocs/reference/tests.md
so it is accessible from docsREADME.md
todocs/reference/quickstart.md
so accessible from docsMiscellaneous
eth_simulateV1
#484