execvp can't return EINTR as far as I can tell, so the wrapper function was overkill

Author: eteran

Diff for: plugins/DebuggerCore/unix/DebuggerCoreUNIX.cpp

@@ -61,18 +61,6 @@ void sigchld_handler(int sig, siginfo_t *info, void *p) {
 
 }
 
-//------------------------------------------------------------------------------
-// Name: execvp
-// Desc: execvp, but handles being interrupted
-//------------------------------------------------------------------------------
-int native::execvp(const char *file, char *const argv[]) {
-	int ret;
-	do {
-		ret = ::execvp(file, argv);
-	} while(ret == -1 && errno == EINTR);
-	return ret;
-}
-
 //------------------------------------------------------------------------------
 // Name: read
 // Desc: read, but handles being interrupted
@@ -449,7 +437,7 @@ void DebuggerCoreUNIX::execute_process(const QString &path, const QString &cwd,
 
 		*p = 0;
 
-		const int ret = native::execvp(argv_pointers[0], argv_pointers);
+		const int ret = execvp(argv_pointers[0], argv_pointers);
 
 		// should be no need to cleanup, the process which allocated all that
 		// space no longer exists!

Diff for: plugins/DebuggerCore/unix/DebuggerCoreUNIX.h

@@ -26,7 +26,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 namespace DebuggerCore {
 
 namespace native {
-	int execvp(const char *file, char *const argv[]);
 	int select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout);
 	int select_ex(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, quint64 msecs);
 	pid_t waitpid(pid_t pid, int *status, int options);