using C++17 fallthrough attribute

Author: eteran

cmake/Modules/AddWarnings.cmake

@@ -22,6 +22,7 @@ function(TARGET_ADD_WARNINGS TARGET)
 			-Wno-unused-macros
 			-Wno-switch-enum
 			-Wno-unknown-pragmas
+			-Wimplicit-fallthrough
 		)
 
 		if(TARGET_COMPILER_CLANG)
@@ -32,7 +33,6 @@ function(TARGET_ADD_WARNINGS TARGET)
 				#-Wshadow-uncaptured-local
 				#-Wshorten-64-to-32
 				-Wconditional-uninitialized
-				-Wimplicit-fallthrough
 				-Wmissing-prototypes
 			)
 
@@ -49,7 +49,6 @@ function(TARGET_ADD_WARNINGS TARGET)
 				#-Wuseless-cast
 				-Wlogical-op
 				-Wsuggest-override
-
 			)
 	    endif()
 	endif()

plugins/ODbgRegisterView/DialogEditGPR.cpp

@@ -183,13 +183,13 @@ void DialogEditGPR::setupEntriesAndLabels() {
 	case 8:
 		hideColumn(GPR8H_COL);
 		hideColumn(GPR16_COL);
-		/* fallthrough */
+		[[fallthrough]];
 	case 16:
 		hideColumn(GPR32_COL);
-		/* fallthrough */
+		[[fallthrough]];
 	case 32:
 		hideColumn(GPR64_COL);
-		/* fallthrough */
+		[[fallthrough]];
 	case 64:
 		break;
 	default:

src/FloatX.cpp

@@ -438,7 +438,7 @@ EDB_EXPORT QString format_float(Float value) {
 
 			std::memcpy(ptr, &exponent, sizeof(exponent));
 		}
-		// fall through
+		[[fallthrough]];
 	case FloatValueClass::Normal:
 	case FloatValueClass::Denormal: {
 #ifdef HAVE_DOUBLE_CONVERSION