Commit 9a9ff62
1 parent 3d6e4e1 commit 9a9ff62
1 file changed
+2
-0
lines changedOriginal file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
28 | 28 |
| |
29 | 29 |
| |
30 | 30 |
| |
| 31 | + | |
| 32 | + | |
31 | 33 |
| |
32 | 34 |
| |
33 | 35 |
| |
|
1 parent 3d6e4e1 commit 9a9ff62
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
28 | 28 |
| |
29 | 29 |
| |
30 | 30 |
| |
| 31 | + | |
| 32 | + | |
31 | 33 |
| |
32 | 34 |
| |
33 | 35 |
| |
|
6 commit comments
JAndrassy commentedon Apr 24, 2019
you should not add new pure virtual function to Arduino API base classes. other networking libraries don't implement them. now Ethernet, UIPEthernet and other Arduino networking libraries can't be used with this core. esp8266 did it in 2.5.0 and now they fix it for 2.5.1 and now esp32 core developers do the same mistake?
beegee-tokyo commentedon Apr 24, 2019
Same problem with TinyGSM after this commit. Doesn't compile anymore.
me-no-dev commentedon Apr 25, 2019
so with or without this change some things do not work. Let's find a common ground and make it work for all. Any proposals?
JAndrassy commentedon Apr 25, 2019
see how the esp8266 core handled it
or like Erhernet library has it would be even better https://www.arduino.cc/en/Reference/EthernetClientSetConnectionTimeout
JAndrassy commentedon May 14, 2019
you still didn't fix this? why do you need to have the
connect
version with timeout in the base class?Ibrahimsyah commentedon Dec 22, 2024
Any update or workaround for this guys? it breaks MqttClient implementation (and other libs that depends on wifiClient i guess)
MqttClient mqttClient(wifiClient);
Currently we can use the older version (v3.0.7) to make it work, but i think this is not a good long term solution as we will miss all latest updates