Skip to content

Merge into main branch rust-lang/rust? #89

Open
@luojia65

Description

@luojia65

By now developers have to compile whole custom Rust toolchain to work with xtensa isa. Is there any possibility to merge xtensa instruction set support into main branch Rust? Then developers can install them easily by using rustup toolchain add command.

Activity

mcilloni

mcilloni commented on Oct 28, 2021

@mcilloni

I don't think this can be done until the Xtensa backend is merged into upstream LLVM, but I could be wrong.

MabezDev

MabezDev commented on Oct 28, 2021

@MabezDev
Member

@mcilloni is correct, Rust won't accept Xtensa support upstream without atleast an experimental backend in LLVM upstream.

With the riscv chips, we've already upstreamed everything we can.

stappersg

stappersg commented on Apr 24, 2022

@stappersg

Where to check the status?

URLs that I'm missing:

  • LLVM xtensa branch
  • issue that describes the merge of xtensa into LLVM
  • issue that describes the merge of "LLVM xtensa" into Rust
paulocsanz

paulocsanz commented on Feb 12, 2023

@paulocsanz

espressif/llvm-project#4 implies that all of the repo's changes have been merged to upstream LLVM, although the PR hasn't been closed yet.

What are the next steps?

igrr

igrr commented on Feb 12, 2023

@igrr

We have indeed got the first patch set merged into LLVM, however that set of patches is not yet sufficient for a working Rust compiler.
We will update the tracking issue with the next series of patches as soon as we post them for review. You can find the entire set of Xtensa patches here: espressif/llvm-project#62.

noahbliss

noahbliss commented on Mar 1, 2024

@noahbliss

Hey guys, just wanted to ping this as it seems there is some new traction over at the tracking issue espressif/llvm-project#4 seems this might be coming pretty close

jessebraham

jessebraham commented on Mar 1, 2024

@jessebraham
Member

seems this might be coming pretty close

My understanding (somebody can correct me if I'm wrong) is that there are still a large number of patches which need to be merged into LLVM before full Xtensa support is realized. Once this is complete, it will take time for these changes to propagate into Rust as well.

SergioGasquez

SergioGasquez commented on Mar 5, 2025

@SergioGasquez
Member

Quick update as we've made some progress about upstreaming our Rust patches, the following PRs were merged:

We are still awaiting on the LLVM upstreaming effort to be able to continue upstreaming our Rust patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @mcilloni@jessebraham@igrr@paulocsanz@MabezDev

        Issue actions

          Merge into main branch rust-lang/rust? · Issue #89 · esp-rs/rust