Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defmt "--log-format" option #781

Open
CvRXX opened this issue Feb 24, 2025 · 5 comments
Open

add defmt "--log-format" option #781

CvRXX opened this issue Feb 24, 2025 · 5 comments
Labels
feature request Request for new feature/functionality serial monitor Issues relating to the serial monitor functionality

Comments

@CvRXX
Copy link

CvRXX commented Feb 24, 2025

With probe-rs you can pass the argument --log-format as described in https://defmt.ferrous-systems.com/custom-log-output#passing-log-format-to-printers. Would it be possible to add this to espflash as well so we can edit the log output?

@jessebraham jessebraham added the feature request Request for new feature/functionality label Feb 25, 2025
@jessebraham
Copy link
Member

At this time we have a fair bit of work ahead of us here, so I'm not sure we will prioritize this right now. However, I think eventually this would be nice functionality to add. We'd be happy to accept a PR from the community, otherwise one of us can revisit this once our current work has been completed.

@SergioGasquez
Copy link
Member

#520 is basically the same issue

@jessebraham
Copy link
Member

#520 is basically the same issue

They're related but different, if I'm understanding correctly. In the linked issue they are asking for a different logging format, this issue is asking for support for providing an arbitrary format string.

@CvRXX
Copy link
Author

CvRXX commented Feb 28, 2025

I would be happy to write a PR. Any things I should consider? I'm a beginning rust programmer (month of experience or so) but am experienced in modern c++

@SergioGasquez
Copy link
Member

Any things I should consider?

I guess this would only apply when using --log-format defmt, maybe we should use --defmt-format name (?). I would suggest you look at probe-rs source for inspiration of this feature, here is my old branch trying to close #520: main...SergioGasquez:espflash:feat/defmt-verbose, dont think it will help you much but just in case.

@jessebraham jessebraham added the serial monitor Issues relating to the serial monitor functionality label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new feature/functionality serial monitor Issues relating to the serial monitor functionality
Projects
Status: Todo
Development

No branches or pull requests

3 participants